[PATCH v2 10/32] bsp/leon3: Use new IRQ(A)MP register block API

[Martin Åberg]

Great to see the new register names being used.

OK. But a minor note below about LEON_Enable_interrupt_broadcast() below.


On 2023-07-05 13:18, Sebastian Huber wrote:
>   
>   #define LEON_Force_interrupt( _source ) \
> -  do { \
> -    LEON3_IrqCtrl_Regs->iforce = (1U << (_source)); \
> -  } while (0)
> +  grlib_store_32(&LEON3_IrqCtrl_Regs->iforce0, 1U << (_source))
>   
>   #define LEON_Enable_interrupt_broadcast( _source ) \
>     do { \
> @@ -207,24 +195,30 @@ extern uint32_t LEON3_Cpu_Index;
>     } while (0)
>   

It looks like LEON_Enable_interrupt_broadcast() and
LEON_Disable_interrupt_broadcast are still accessing the
register by dereferencing LEON3_IrqCtrl_Regs->bcast directly,
in contrast to the other changes in the file. (These two macros
are not used anywhere at the moment.)


-- 
Best regards,

Martin Åberg
Software Engineer
Frontgrade Gaisler
martin.aberg at gaisler.com

Frontgrade Gaisler AB, Kungsgatan 12, SE-411 19 GÖTEBORG, Sweden.
+46 (0) 31 775 8650, www.gaisler.com