grlib changes Fwd: New Defects reported by Coverity Scan for RTEMS

[Gedare Bloom]

Sebastian fixed it now. The local variable was shadowed. Another good
reason to keep local variables at the start of a function ;)

On Sat, Jul 15, 2023 at 9:38 AM Joel Sherrill <joel at rtems.org> wrote:
>
>
> The recent grlib changes introduced a Coverity issues.
>
> ---------- Forwarded message ---------
> From: <scan-admin at coverity.com>
> Date: Sat, Jul 15, 2023 at 12:22 AM
> Subject: New Defects reported by Coverity Scan for RTEMS
> To: <build at rtems.org>
>
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to RTEMS found with Coverity Scan.
>
> 1 new defect(s) introduced to RTEMS found with Coverity Scan.
>
>
> New defect(s) Reported-by: Coverity Scan
> Showing 1 of 1 defect(s)
>
>
> ** CID 1538314:  Uninitialized variables  (UNINIT)
> /bsps/shared/grlib/uart/apbuart_cons.c: 448 in first_open()
>
>
> ________________________________________________________________________________________________________
> *** CID 1538314:  Uninitialized variables  (UNINIT)
> /bsps/shared/grlib/uart/apbuart_cons.c: 448 in first_open()
> 442                             return false;
> 443                     }
> 444
> 445                     uart->sending = 0;
> 446
> 447                     /* Turn on RX interrupts */
> >>>     CID 1538314:  Uninitialized variables  (UNINIT)
> >>>     Using uninitialized value "ctrl".
> 448                     ctrl |= APBUART_CTRL_RI;
> 449                     if (uart->cap & CAP_DI) {
> 450                             /* Use RX FIFO interrupt only if delayed interrupt available. */
> 451                             ctrl |= (APBUART_CTRL_DI | APBUART_CTRL_RF);
> 452                     }
> 453             }
>
>
> ________________________________________________________________________________________________________
> To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypUUzi-2FdSNmuyRB7BEFT8xQ4-2B8hpujh0hTgQljRGId4Dg-3D-3DHAM__EU3W9teASMK00lBXX9WT4lsogDrkCcNZLvg-2FVxwAXMo-2BfWe9y-2FQVPI3NBuKOOB9pEF0PWPhWQO6FUVOcAwwdagvzNKH7AA8SymQIigXNwofEBIHyLL-2FrZJgQDgEg0O4g4HS-2FjBhvvcGAhWWb-2FxsDZrRDyXAMAUd-2BRwY7jJKszizp8zBz7IR2apEMP0z49hqJcf-2F9hLs1Dn-2B7C8NzR5v-2Bdg-3D-3D
>
> _______________________________________________
> build mailing list
> build at rtems.org
> http://lists.rtems.org/mailman/listinfo/build
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel