[PATCH] bsps/arm: fix nested extern decl. warnings brought by CMSIS files update

[Karel Gardas]

On 7/25/23 17:23, Sebastian Huber wrote:
> On 25.07.23 16:20, Karel Gardas wrote:
>> On 7/25/23 15:32, Sebastian Huber wrote:
>>>
>>>
>>> On 21.07.23 17:37, Karel Gardas wrote:
>>>> ---
>>>>   bsps/arm/include/cmsis_gcc.h | 4 +++-
>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/bsps/arm/include/cmsis_gcc.h 
>>>> b/bsps/arm/include/cmsis_gcc.h
>>>> index 4f0762d6dc..9e867348d2 100644
>>>> --- a/bsps/arm/include/cmsis_gcc.h
>>>> +++ b/bsps/arm/include/cmsis_gcc.h
>>>> @@ -30,7 +30,9 @@
>>>>   #pragma GCC diagnostic ignored "-Wsign-conversion"
>>>>   #pragma GCC diagnostic ignored "-Wconversion"
>>>>   #pragma GCC diagnostic ignored "-Wunused-parameter"
>>>> -
>>>> +#ifdef __rtems__
>>>> +#pragma GCC diagnostic ignored "-Wnested-externs"
>>>> +#endif /* __rtems__ */
>>>>   /* Fallback for __has_builtin */
>>>>   #ifndef __has_builtin
>>>>     #define __has_builtin(x) (0)
>>>
>>> I would disable this warning only in __cmsis_start() with a push/pop 
>>> pragma.

Done!

> Ideally, the guidelines would be in the RTEMS Software Engineering 
> manual before we added the Apache 2.0 files. We should avoid that every 
> contributor has to figure out what to do. I you think that this 
> __rtems__ stuff is enough, then just document it. Zephyr for example has 
> a clear process to add new licenses:
> 
> https://docs.zephyrproject.org/latest/contribute/external.html

Indeed, but we're not living in ideal world unfortunately. Zephyr is 
completely different league in terms of man-power available to the 
project. We need to live with what we have.

Anyway, I've submitted new version of the patch and hopefully also be 
more compliant with the terms of the Apache 2.0 license.

Thanks!
Karel