[PATCH 2/2] bsps: Remove uses of BSP-specific interrupt API

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Jun 16 04:51:47 UTC 2023


On 16.06.23 03:49, Chris Johns wrote:
>> diff --git a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c
>> index 96b77907a6..bc211e37b6 100644
>> --- a/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c
>> +++ b/bsps/shared/grlib/drvmgr/ambapp_bus_grlib.c
>> @@ -41,7 +41,7 @@
>>   #include <grlib/genirq.h>
>>   
>>   #include <bsp.h>
>> -#include <bsp/irq.h>
>> +#include <bsp/irq-generic.h>
>>   
>>   #include <grlib/grlib_impl.h>
>>   
>> @@ -227,7 +227,7 @@ static int ambapp_grlib_int_clear
>>   	struct drvmgr_dev *dev,
>>   	int irq)
>>   {
>> -	BSP_shared_interrupt_clear(irq);
>> +	(void) rtems_interrupt_clear(irq);
>>   	return DRVMGR_OK;
> Why ignore the return code of the clear and assume the result is OK?
> 
> This pattern is repeated in other places.

This is how it is. I didn't want to introduce functional or API changes 
with this patch set.

-- 
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list