[rtems commit] libdl: Add support to import base image TLS symbols

Chris Johns chrisj at rtems.org
Mon Sep 18 21:17:45 UTC 2023


On 18/9/2023 10:09 pm, Sebastian Huber wrote:
> On 17.09.23 00:58, Chris Johns wrote:
>>> There are also no test cases for this function.
>>> Without test cases it is easy to break something without knowing it.
>> The libdl test cases have been updated to reference TLS newlib variables to test
>> this. Is that enough? If not what would you like to see?
> 
> These higher level tests are all right, however, it would be nice to have also
> lower level tests which just check a particular function like
> rtems_rtl_tls_get_base(). This would improve the maintainability of this stuff.
> You would not have to debug a tool generated code to figure out what is wrong.

This makes sense. I will think about a suitable test.

Chris


More information about the devel mailing list