[PATCH rtems-lwip 00/10] RTEMS LWIP clean up

[berndmoessner80 at gmail.com]

From: Bernd Moessner <berndmoessner80 at gmail.com>

This patch set:

a) Changes the submodule paths to https so that the project can be
checked out in restricted network environments

b) Fixes a bug in lwip.py. The library search path wasnt set up so
it was only possible to install rtems-lwip in the rtems install
folder.

c) Removes some header files provided by XLNX as they are already
included in RTEMS. In addition to that Ive update def bsp def and
remove some dead include search paths.

d) Has rtems-lwip ever been compile clean for XLNX? I observe some
warnings coming from the XLNX adapter code (complaints about
incompatible pointers). Most of them orginate in the fact that
XLNX tries to use the more generic ip_addr_t pointer type and feeds
them into functions which expect ip4_addr_t. I`ll try to feed the
patches back to XLNX if they are ok.

e) I havnt understood why there is a #define LWIP_COMPAT_SOCKETS 0
in rtems_lwip_io.c. The macro is defined to 1 in lwipopts.h, and
lwipopts.h gets pulled in too. Hence, I get a compiler warning
due to the redefinition. To my understanding it has to be defined
to 1 or 2. Therefore, I am a bit puzzled as I neither understand
why it is defined in this file, nor why it has a value of 0? I've
removed the define in rtems_lwip_io.c, hope I havent broken things
due to my lack of understanding.


Bernd Moessner (10):
  FIX: adjust submodule path to allow checkout in restricted network
    environments
  FIX: add library search path to allow lwip being installed aside the
    RTEMS installation
  Clean up: remove non-existent include paths
  FIX: warning variable might be used without initialization
  FIX: remove header files which are already provided by RTEMS
  FIX: printf format spec compiler warning due to uintptr having 64bits
    on 64bit machines
  FIX: incompatible pointer warning
  FIX incompatible pointer warning
  FIX incompatible pointer warning
  FIX compiler warning due to macro redefinition

 .gitmodules                                   |   4 +-
 defs/bsps/aarch64/xilinx_zynqmp_base.json     |   5 +-
 .../src/contrib/ports/xilinx/netif/xadapter.c |   8 +-
 .../contrib/ports/xilinx/netif/xemacpsif.c    |  23 +-
 .../src/arm/ARMv8/64bit/xil_cache.h           |  75 ----
 .../standalone/src/arm/common/xil_exception.h | 408 ------------------
 lwip.py                                       |   7 +-
 rtemslwip/common/rtems_lwip_io.c              |   2 -
 rtemslwip/common/sys_arch.c                   |   2 +-
 rtemslwip/xilinx/xil_printf.h                 |  33 --
 rtemslwip/xilinx/xil_smc.h                    |   1 -
 11 files changed, 27 insertions(+), 541 deletions(-)
 delete mode 100644 embeddedsw/lib/bsp/standalone/src/arm/ARMv8/64bit/xil_cache.h
 delete mode 100644 embeddedsw/lib/bsp/standalone/src/arm/common/xil_exception.h
 delete mode 100644 rtemslwip/xilinx/xil_printf.h
 delete mode 100644 rtemslwip/xilinx/xil_smc.h

-- 
2.34.1