[PATCH rtems6 - v1 05/16] FIX: Add missing default case

[Joel Sherrill]

https://docs.rtems.org/branches/master/eng/vc-users.html#commit-message-guidance

If that is missing something, please ask questions and we can address the
Software Engineering Guide.

--joel

On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner <berndmoessner80 at gmail.com>
wrote:

> Dear Kinsey,
>
> sry for the stupid question. What is the correct way to reference the issue
>
> [#4981 <https://devel.rtems.org/ticket/4981> rtems6 - v1 05/16] FIX: Add
> missing default case
>
> or
>
> [PATCH rtems6 - v1 05/16] #4981 <https://devel.rtems.org/ticket/4981>
> FIX: Add missing default case
>
> ?
>
>
>
>
> On 04.01.2024 19:48, Kinsey Moore wrote:
> > All of the patches here need an issue reference. Beyond that, this
> > patch is good to go in. I'm still reviewing the remainder of the set
> > and I'll leave the renaming discussion to Aaron.
> >
> > Kinsey
> >
> > On Thu, Jan 4, 2024 at 12:35 PM <berndmoessner80 at gmail.com> wrote:
> >
> >     From: Bernd Moessner <berndmoessner80 at gmail.com>
> >
> >     ---
> >      cpukit/dev/flash/flashdev.c | 2 ++
> >      1 file changed, 2 insertions(+)
> >
> >     diff --git a/cpukit/dev/flash/flashdev.c
> b/cpukit/dev/flash/flashdev.c
> >     index 27edead968..8bd3d11246 100644
> >     --- a/cpukit/dev/flash/flashdev.c
> >     +++ b/cpukit/dev/flash/flashdev.c
> >     @@ -390,6 +390,8 @@ static int rtems_flashdev_ioctl(
> >          case RTEMS_FLASHDEV_IOCTL_GET_WRITE_BLOCK_SIZE:
> >            err = rtems_flashdev_ioctl_get_write_block_size( flash, arg );
> >            break;
> >     +    default:
> >     +      err = EINVAL;
> >        }
> >
> >        rtems_flashdev_release( flash );
> >     --
> >     2.34.1
> >
> >     _______________________________________________
> >     devel mailing list
> >     devel at rtems.org
> >     http://lists.rtems.org/mailman/listinfo/devel
> >
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20240104/82cb9039/attachment.htm>