[PATCH] Do not define CONFIGURE_TICKS_PER_TIMESLICE to 0

Sebastian Huber sebastian.huber at embedded-brains.de
Wed Mar 20 14:22:55 UTC 2024


On 20.03.24 15:14, Joel Sherrill wrote:
> This is generally ok but it contradicts the documented behavior 
> for CONFIGURE_TICKS_PER_TIMESLICE which states "The value of the 
> configuration option shall be greater than or equal to zero."

This is the problem of the referenced ticket:

https://devel.rtems.org/ticket/4986

> 
> If zero is to be an error, then that needs to change.

This is what the patch does.

> 
> Further, this series of changes has made me realize that 
> CONFIGURE_TICKS_PER_TIMESLICE and CONFIGURE_MICROSECONDS_PER_TICK should 
> not be defined if the application has not defined 
> CONFIGURE_APPLICATION_NEEDS_CLOCK_DRIVER. Currently the documentation 
> just says it has no effect.

This is a different topic. I would like to first fix the undefined 
behaviour if some uses:

#define CONFIGURE_TICKS_PER_TIMESLICE 0

> 
> Also the formatting of the text in the description is inconsistent. 
> Could a ref be used for all of this?
> 
> The application shall define exactly one of the following configuration 
> options
> 
> * :ref:`CONFIGURE_APPLICATION_NEEDS_CLOCK_DRIVER`,
> * ``CONFIGURE_APPLICATION_DOES_NOT_NEED_CLOCK_DRIVER``, or
> * :ref:`CONFIGURE_APPLICATION_NEEDS_TIMER_DRIVER`,

Sorry, were is this in the patch?

-- 
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber at embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/


More information about the devel mailing list