can we include dosfs?

Mon Jun 20 12:24:36 UTC 2016

On Mon, Jun 20, 2016 at 4:55 AM, Joel Sherrill <joel at rtems.org> wrote:
>
> On Jun 19, 2016 8:51 PM, "Ben Gras" <beng at shrike-systems.com> wrote:
>>
>> On Mon, Jun 20, 2016 at 4:33 AM, Chris Johns <chrisj at rtems.org> wrote:
>> > On 20/06/2016 12:24, Ben Gras wrote:
>> >>
>> >> I'm looking at building umon from RSB, to replace uboot, the next step
>> >> to mainlining all the beagle bsp support.
>> >
>> >
>> > Great.
>> >
>> >> It seems umon doesn't read FAT filesystems. Does anyone see any
>> >> license objection to including
>> >> dosfs.c (http://www.zws.com/products/dosfs/) as seems to have happened
>> >> with the original umon?
>> >
>> >
>> > How does that implementation compare with
>> > http://elm-chan.org/fsw/ff/00index_e.html? This is used by Xilinx in the
>> > first stage bootloader.
>>
>> They look similar enough. They both rely on some low-level device
>> access functions
>> to be provided by the user, which is fine. The license isn't terribly
>> clear I think:
>>
>> / FatFs module is a free software that opened under license policy of
>> / following conditions.
>> /
>> / Copyright (C) 2016, ChaN, all right reserved.
>> /
>> / 1. Redistributions of source code must retain the above copyright
>> notice,
>> /    this condition and the following disclaimer.
>> /
>> / This software is provided by the copyright holder and contributors "AS
>> IS"
>> / and any warranties related to this software are DISCLAIMED.
>> / The copyright owner or contributors be NOT LIABLE for any damages caused
>> / by use of this software.
>>
>> Do you think we can include it?
>
> Looks like MIT more or less to me. So no license issues that I see.

Great.

> Review the one Chris suggested though.
>
>> The dosfs license is, though unfortunately not any standard license,
>> clearer with
>> the no-strings-attached language, and I know it has been hooked up to
>> umon before,
>> so that seems lower-risk to me at the moment.
>
> What's the license say?

License
=======
The license for DOSFS is very simple but verbose to state.

1. DOSFS is (C) Copyright 2006 by Lewin A.R.W. Edwards ("Author").
   All rights not explicitly granted herein are reserved. The DOSFS
   code is the permanent property of the Author and no transfer of
   ownership is implied by this license.

2. DOSFS is an educational project, provided as-is. No guarantee of
   performance or suitability for any application is stated or
   implied. You use this product entirely at your own risk. Use of
   this product in any manner automatically waives any right to seek
   compensation or damages of any sort from the Author. Since the
   products you might make are entirely out of the Author's control,
   use of this product also constitutes an agreement by you to take
   full responsibility for and indemnify the Author against any
   action for any loss or damage (including economic loss of any
   type, and specifically including patent litigation) that arises
   from a product made by you that incorporates any portion of
   the DOSFS code.

3. If you live under the jurisdiction of any legislation that would
   prohibit or limit any condition in this license, you cannot be
   licensed to use this product.

4. If you do not fall into the excluded category in point 3, you are
   hereby licensed to use the DOSFS code in any application that you
   see fit. You are not required to pay any fee or notify the Author
   that you are using DOSFS. Any modifications made by you to the
   DOSFS code are your property and you may distribute the modified
   version in any manner that you wish. You are not required to
   disclose sourcecode to such modifications, either to the Author or
   to any third party. Any such disclosure made to the Author will
   irrevocably become the property of the Author in the absence of a
   formal agreement to the contrary, established prior to such
   disclosure being made.

To summarize the intent of the above: DOSFS is free. You can do what
you want with it. Anything that happens as a result is entirely your
responsibility. You can't take ownership of my code and stop me from
doing whatever I want with it. If you do something nifty with DOSFS
and send me the sourcecode, I may include your changes in the next
distribution and it will be released to the world as free software.
If someone sues you because your DOSFS-containing product causes
any sort of legal, financial or other problem, it's your lawsuit,
not mine, and you'll exclude me from the proceedings.

Chris do you prefer http://elm-chan.org/fsw/ff/00index_e.html ?

>> > I also have a JFFS bootloader implementation that can be added so umon
>> > can
>> > be booted from a JFFS2.
>> >
>> >> Can we then include the original umon CLI interface or is that a
>> >> license issue? If so I can re-implement it.
>> >
>> >
>> > I do not know and yes it would be nice to use what is available.
>>
>> Let's see what Ed says about including the CLI code. It is e.g.:
>>
>>
>> http://users.ece.utexas.edu/~mcdermot/arch/projects_fall_09/Team_07/umon-1.17/umon_main/target/common/fatfs.c
>
> +1
>
>>
>> > Chris
>> > _______________________________________________
>> > umon-devel mailing list
>> > umon-devel at rtems.org
>> > http://lists.rtems.org/mailman/listinfo/umon-devel
>> _______________________________________________
>> umon-devel mailing list
>> umon-devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/umon-devel