[PATCH] if_fxp: do not initialize PCI bus itself

Karel Gardas kgardas at objectsecurity.com
Thu Aug 18 19:04:24 UTC 2005


Hello,

if_fxp NIC driver worked well on pc386 BSP, since it initializes PCI bus 
itself. Experts here pointed out that this is wrong way early this year 
and I've finally removed this initialization from the driver and tested 
that it still works with the pc386 BSP with previous PCI bus init patch 
applied. Hopefuly this is also right for other supported platforms.

Cheers,
Karel
--
Karel Gardas                  kgardas at objectsecurity.com
ObjectSecurity Ltd.           http://www.objectsecurity.com
-------------- next part --------------
Index: c/src/ChangeLog
===================================================================
RCS file: /usr1/CVS/rtems/c/src/ChangeLog,v
retrieving revision 1.259
diff -u -r1.259 ChangeLog
--- c/src/ChangeLog	15 Aug 2005 13:54:15 -0000	1.259
+++ c/src/ChangeLog	18 Aug 2005 18:51:16 -0000
@@ -1,3 +1,7 @@
+2005-08-18  Karel Gardas  <kgardas at objectsecurity.com>
+
+	* libchip/network/if_fxp.c: Remove initialization of PCI bus.
+
 2005-08-15	Ralf Corsepius <ralf.corsepius at rtems.org>
 
 	* optman/Makefile.am: Add preinstall.am.
Index: c/src/libchip/network/if_fxp.c
===================================================================
RCS file: /usr1/CVS/rtems/c/src/libchip/network/if_fxp.c,v
retrieving revision 1.16
diff -u -r1.16 if_fxp.c
--- c/src/libchip/network/if_fxp.c	18 Jul 2005 15:42:24 -0000	1.16
+++ c/src/libchip/network/if_fxp.c	18 Aug 2005 18:51:37 -0000
@@ -447,16 +447,6 @@
 	s = splimp();
 
 	/*
-	 * init PCI Bios interface...
-	 */
-	i = pci_initialize();
-	DBGLVL_PRINTK(2,"fxp_attach: pcib_init returned %d\n",i);
-	if (i != PCIB_ERR_SUCCESS) {
-	  device_printf(dev, "could not initialize pci bios interface\n");
-	  return 0;
-	}
-
-	/*
 	 * find device on pci bus
 	 */
     { int j; int pbus, pdev, pfun;


More information about the users mailing list