[PATCH] if_fxp: do not initialize PCI bus itself
strauman at slac.stanford.edu
Fri Aug 19 19:11:08 UTC 2005
On Friday 19 August 2005 04:28 am, Jennifer Averett wrote:
> > Karel Gardas wrote:
> >> Hello,
> >> if_fxp NIC driver worked well on pc386 BSP, since it initializes PCI bus
> >> itself. Experts here pointed out that this is wrong way early this year
> >> and I've finally removed this initialization from the driver and tested
> >> that it still works with the pc386 BSP with previous PCI bus init patch
> >> applied. Hopefuly this is also right for other supported platforms.
> > This steps into more of a grey area to me. It looks like
> > pci_initialize() is called from bspstart.c for every BSP that calls
> > it. So that assumption is safe.
> > However, it also looks like other drivers in libchip/network
> > call pci_initialize(). So if it is correct to remove
> > the call to pci_initialize() from the if_fxp driver, it must
> > also be correct to do from the other drivers.
> > I need to either not apply the patch or remove the call
> > to pci_initialize from the other drivers. If we do the latter,
> > we are assuming that the BSP will take care of that for
> > device drivers.
> > Comments?
> > --joel
> IMO, it seems more appropriate to let the BSP take care of it.
> when multiple libchip drivers are used pci_initialize could be called
> multiple times.
More information about the users