pc386 BSP install fails: pr743 side-effect ?

[Joel Sherrill <joel@OARcorp.com>]

Ralf Corsepius wrote:
> On Mon, 2005-05-23 at 10:56 +1000, Chris Johns wrote:
> 
>>Joel Sherrill <joel at OARcorp.com> wrote:
>>
>>>Looks like a typo. Try this patch and let us know.
>>>
>>
>>That patch did not work but this one does. Ralf, is this ok to commit to 
>>the rtrems-4-6-branch ?
> 
> No. Using the gnumake proprietary vpath and %.c rules is never correct.
> 
> This bugs is known (at least to me) since the earliest days of 4.6, and
> has been fixed a long time ago on 4.7. I haven't tried to fix it in 4.6
> and will not fix it there, because to me, 4.6 is dead and not worth to
> look into it again.
> 
> You'll have to adjust VPATH to pickup the correct file or to use
> relative paths.

The patch feedback went private.

I moved the install of tod.h to include and fixed the CLEANFILES typo.

My current patch is attached.  It seems to work.  What do you think?


>>Index: Makefile.am
>>===================================================================
>>RCS file: 
>>/usr1/CVS/rtems/c/src/lib/libbsp/i386/pc386/clock/Attic/Makefile.am,v
>>retrieving revision 1.7.2.2
>>diff -p -u -r1.7.2.2 Makefile.am
>>--- Makefile.am 20 Jan 2005 16:54:45 -0000      1.7.2.2
>>+++ Makefile.am 23 May 2005 00:32:45 -0000
>>@@ -2,7 +2,7 @@
>>  ## $Id: Makefile.am,v 1.7.2.2 2005/01/20 16:54:45 joel Exp $
>>  ##
>>
>>-VPATH = @srcdir@:@srcdir@/../../shared/tod:@srcdir@/../../../shared
>>+vpath %.c @srcdir@:@srcdir@/../../shared/tod:@srcdir@/../../../shared
>>
>>  PGM = $(ARCH)/clock.rel
>>
>>@@ -13,7 +13,7 @@ include_HEADERS = tod.h
>>
>>  tod.h: $(top_srcdir)/../../shared/tod.h
>>         cp $< $@
>>-CLEANFILES = tod
>>+CLEANFILES = tod.h
>>
>>  $(PROJECT_INCLUDE):
>>         $(mkinstalldirs) $@
> 
> 
> Ralf
> 
> 


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel at OARcorp.com                 On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
    Support Available             (256) 722-9985

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pc386.diff
URL: <http://lists.rtems.org/pipermail/users/attachments/20050523/8f85f4f9/attachment-0001.ksh>