GNATS-1110: in_cksum_hdr error in PC386 BSP
ralf.corsepius at rtems.org
Wed Jun 28 14:39:59 UTC 2006
On Wed, 2006-06-28 at 08:47 -0500, Eric Norum wrote:
> The checksum routines are very heavily used so it's really important
> that they be as fast as possible. Do you have an estimate of the
> relative times of the old and new versions of this code?
heavily used and broken don't align smoothly.
Either these routines have been heavily used, then they must have been
working, or not - Then I don't understand why nobody has tripped over
this issue in the years this code is in place.
> If there are no objections in the next little while I'll commit the
> above change. Joel has been asking for someone to fix the qemu
> problem for a long time. Thank you very much for looking into this.
Take this as an objection to the patch.
IMO, the PR is way to vague to give any trust in it.
More information about the users