warning removal changes

Joel Sherrill joel.sherrill at oarcorp.com
Mon Sep 11 17:02:50 UTC 2006

Jerry Needell wrote:
> Joel - Just a heads-up while I keep debugging. Your "clean-up" broke 
> something in cpukit/libnetworking/netinet/in_cksum.c for the sparc 
> leon3 bsp.
> When I tried to use the etherenet driver, it would hang in an infinite 
> loop in in_cksum.c. I mad a few quick changes to "undo" your recent 
> modifications and everything works fine. I'm trying to understand why 
> but I thought I'd let you know. Maybe the culprit will leap out at you.
There were two CVS commits.  From 1.11 -> 1.12, the change was from an 
int cast to
(intptr_t) around line 120.  I doubt that broke it.

 From 1.10-> 1.11, I see that I changed two things.  I added "L" onto 
the 65535's
in ADDCARRY.  I doubt that broke anything.  But later in the file, I 
changed some ints
to uint32_t's.  Can you try changing those back to int32_t?

 cvs diff -r 1.10 -r 1.11 -u in_cksum.c

to see the change.  It almost has to be adding the unsigned.

Let me know what works and post the diff.  There wasn't much changed.

> - Jerry
> Joel Sherrill wrote:
>> Hi,
>> I have made numerous hopefully safe changes to eliminate
>> warnings over the past few days. My goal was to significantly
>> reduce the number of warnings on 16-bit targets but since
>> all the code in question was target independent, it impacted
>> other targets.  I eliminated over 1000 warnings for h8300/multilib
>> and about 1/2 for sparc/erc32.
>> Please update your tree and test.  If you see problems or
>> have fixes for other warnings, please help.
>> We are primarily dealing with 16/32 bit integer issues and
>> pointer mangling that gcc doesn't like.  I would like to
>> be warning free. :)
>> Thanks.
>> --joel

More information about the users mailing list