RAWish terminal settings in shell

[Chris Johns]

On 9/03/11 9:08 PM, Peter Dufault wrote:
>
> On Mar 9, 2011, at 4:24 , Chris Johns wrote:
>
>> Yes. I am not opposed to setting the terminal to the original setting
>> before calling the command. As stated the concern is breaking existing
>> tested commands that happen to work because of the current settings.
>
> Take a look at the shell loop - it sets the rawish settings before calling the user-hook, it overwrites the normal settings (and then restores them when the command returns).  The thing that's odd is the shell puts the input in a half-baked mode: No echo, no CR translation, no EOF, but still record oriented.  That's an unusual mode, code that requires that should set it itself.

I can see the mode being set to raw when the shell is created but I do 
not see any further changes in the command processing loop. Setting the 
mode to raw in the shell's command line processor is ok because it need 
this mode. My understanding of the issue is what the mode should be for 
the call is the user's command handler.

Chris