cleaner & greener (was Re: A patch for RTEMS4.10.0 PowerPC heap space initialization)

Kate Feng feng1 at bnl.gov
Fri May 13 15:08:53 UTC 2011


Sebastian Huber wrote:
> On 05/13/2011 04:13 PM, Kate Feng wrote:
>   
>> +++ rtems-4.10.0/c/src/lib/libbsp/shared/bootcard.c	2011-05-13 09:53:27.000000000 -0400
>> @@ -53,6 +53,7 @@
>>  
>>  #include <bsp/bootcard.h>
>>  #include <rtems/bspIo.h>
>> +#include <rtems/malloc.h>
>>  
>>  /*
>>   *  At most a single pointer to the cmdline for those target
>> @@ -65,6 +66,9 @@
>>   */
>>  extern bool rtems_unified_work_area;
>>  
>> +static uintptr_t heap_sbrk_spared=0;
>> +extern uintptr_t _bsp_sbrk_init(uintptr_t, uintptr_t*);
>>     
>
> The _bsp_sbrk_init() function is only available on PowerPC.
>
>   
Thanks for your feedback.  How about the attached ?
I added _bsp_sbrk_init() for other BSPs at
c/src/lib/libbsp/shared/sbrk.c.  According to Joel, it would be needed
in the future.  The name seems to be OK at this level, unless Joel comes
up with a different name. One could fill in the function when the memory
protection is implemented.  It seems that other
non-PPC BSPs all use the sbrk() from c/src/lib/libbsp/shared/sbrk.c.

More comments before PR ?

Thanks,
Kate

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtems-4.10.0-heapspace_05132011.diff
Type: text/x-patch
Size: 3139 bytes
Desc: not available
URL: <http://lists.rtems.org/pipermail/users/attachments/20110513/b9d583d1/attachment-0001.bin>


More information about the users mailing list