change log for rtems (2010-07-26)

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Jul 26 14:22:14 UTC 2010


On 07/26/2010 04:10 PM, rtems-vc at rtems.org wrote:
>  *joel*
> 
> 2010-07-26	Joel Sherrill <joel.sherrilL at OARcorp.com>
> 
> 	* rtems/src/ratemonperiod.c: Use if not switch since all cases of enum
> 	are not valid and switch was generating dead code.

I don't think that the following rule is useful:

enum E {
  A,
  B,
  C
};

Replace

switch (e) {
  case A:
    a();
    return S;
  case B;
    b();
    return S;
  case C:
    break;
}
return -S;

with

if (e == A) {
  a();
  return S;
}
if (e == B) {
  b();
  return S;
}
return -S;

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the vc mailing list