change log for rtems (2010-06-29)

Joel Sherrill joel.sherrill at OARcorp.com
Tue Jun 29 15:06:27 UTC 2010


On 06/29/2010 09:26 AM, Ralf Corsepius wrote:
> On 06/29/2010 04:12 PM, rtems-vc at rtems.org wrote:
>    
>>    *jennifer*:
>> 2010-06-29	Joel Sherrill<Joel.Sherrill at OARcorp.com>
>>
>> 	* configure.ac: Added AC_CHECK_SIZEOF macro.
>>
>> M   1.10  c/src/lib/libbsp/powerpc/beatnik/ChangeLog
>> M    1.2  c/src/lib/libbsp/powerpc/beatnik/configure.ac
>> M   1.86  c/src/lib/libbsp/powerpc/ep1a/ChangeLog
>> M   1.13  c/src/lib/libbsp/powerpc/ep1a/configure.ac
>> M  1.147  c/src/lib/libbsp/powerpc/gen5200/ChangeLog
>> M   1.17  c/src/lib/libbsp/powerpc/gen5200/configure.ac
>> M   1.94  c/src/lib/libbsp/powerpc/gen83xx/ChangeLog
>> M   1.12  c/src/lib/libbsp/powerpc/gen83xx/configure.ac
>> M   1.32  c/src/lib/libbsp/powerpc/haleakala/ChangeLog
>> M    1.8  c/src/lib/libbsp/powerpc/haleakala/configure.ac
>> M  1.171  c/src/lib/libbsp/powerpc/mbx8xx/ChangeLog
>> M   1.32  c/src/lib/libbsp/powerpc/mbx8xx/configure.ac
>> M  1.155  c/src/lib/libbsp/powerpc/motorola_powerpc/ChangeLog
>> M   1.34  c/src/lib/libbsp/powerpc/motorola_powerpc/configure.ac
>> M   1.54  c/src/lib/libbsp/powerpc/mpc55xxevb/ChangeLog
>> M   1.12  c/src/lib/libbsp/powerpc/mpc55xxevb/configure.ac
>> M  1.150  c/src/lib/libbsp/powerpc/mpc8260ads/ChangeLog
>> M   1.33  c/src/lib/libbsp/powerpc/mpc8260ads/configure.ac
>> M   1.49  c/src/lib/libbsp/powerpc/mvme3100/ChangeLog
>> M    1.8  c/src/lib/libbsp/powerpc/mvme3100/configure.ac
>> M  1.123  c/src/lib/libbsp/powerpc/mvme5500/ChangeLog
>> M   1.15  c/src/lib/libbsp/powerpc/mvme5500/configure.ac
>> M  1.178  c/src/lib/libbsp/powerpc/psim/ChangeLog
>> M   1.34  c/src/lib/libbsp/powerpc/psim/configure.ac
>> M   1.16  c/src/lib/libbsp/powerpc/qemuppc/ChangeLog
>> M    1.4  c/src/lib/libbsp/powerpc/qemuppc/configure.ac
>> M  1.181  c/src/lib/libbsp/powerpc/score603e/ChangeLog
>> M   1.35  c/src/lib/libbsp/powerpc/score603e/configure.ac
>> M   1.65  c/src/lib/libbsp/powerpc/ss555/ChangeLog
>> M   1.16  c/src/lib/libbsp/powerpc/ss555/configure.ac
>> M   1.51  c/src/lib/libbsp/powerpc/tqm8xx/ChangeLog
>> M    1.9  c/src/lib/libbsp/powerpc/tqm8xx/configure.ac
>> M   1.59  c/src/lib/libbsp/powerpc/virtex/ChangeLog
>> M    1.8  c/src/lib/libbsp/powerpc/virtex/configure.ac
>> M  1.153  c/src/lib/libbsp/sparc/erc32/ChangeLog
>> M   1.28  c/src/lib/libbsp/sparc/erc32/configure.ac
>> M   1.72  c/src/lib/libbsp/sparc/leon2/ChangeLog
>> M   1.15  c/src/lib/libbsp/sparc/leon2/configure.ac
>> M   1.96  c/src/lib/libbsp/sparc/leon3/ChangeLog
>> M   1.15  c/src/lib/libbsp/sparc/leon3/configure.ac
>>
>> diff -u rtems/c/src/lib/libbsp/powerpc/beatnik/ChangeLog:1.9 rtems/c/src/lib/libbsp/powerpc/beatnik/ChangeLog:1.10
>> --- rtems/c/src/lib/libbsp/powerpc/beatnik/ChangeLog:1.9	Mon May 10 09:08:33 2010
>> +++ rtems/c/src/lib/libbsp/powerpc/beatnik/ChangeLog	Tue Jun 29 08:44:02 2010
>> @@ -1,3 +1,7 @@
>> +2010-06-29	Joel Sherrill<Joel.Sherrill at OARcorp.com>
>> +
>> +	* configure.ac: Added AC_CHECK_SIZEOF macro.
>> +
>>    2010-05-10	Joel Sherrill<joel.sherrilL at OARcorp.com>
>>
>>    	* include/bsp.h: Do not include<bsp/bsp_bsdnet_attach.h>   if networkign
>>
>> diff -u rtems/c/src/lib/libbsp/powerpc/beatnik/configure.ac:1.1 rtems/c/src/lib/libbsp/powerpc/beatnik/configure.ac:1.2
>> --- rtems/c/src/lib/libbsp/powerpc/beatnik/configure.ac:1.1	Thu Dec  3 10:56:22 2009
>> +++ rtems/c/src/lib/libbsp/powerpc/beatnik/configure.ac	Tue Jun 29 08:44:02 2010
>> @@ -20,6 +20,10 @@
>>    RTEMS_CHECK_NETWORKING
>>    AM_CONDITIONAL(HAS_NETWORKING,test "$HAS_NETWORKING" = "yes")
>>
>> +## This is needed to generate the field offsets of the per CPU
>> +## data structure so they can be accessed from assembly code.
>> +AC_CHECK_SIZEOF([void *])
>>
>>      
> Joel, without having checked in detail what you are doing, ... in the
> light of "SW design principles" what you are doing is a very ugly design.
>
>    
The SIZEOF_VOID was implemented at your suggestion.
It is unfortunate that files inside libcpu and libbsp need to
be able to have that defined just like the cpukit.  I don't
like it either but it is NOT in a publicly installed .h file
from cpukit.

The best solution would be to have this value (by any
name) in cpuopts.h so it is automatically available. If you
can add the code to cpukit somewhere that makes this
value (by any name) available via something installed by
the cpukit, then I am happy to revert the BSP and libcpu
configure.ac changes.

I really don't like them either so am happy for you to
propose a better alternative.

> Ralf
>
> _______________________________________________
> rtems-vc mailing list
> rtems-vc at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-vc
>    


-- 
Joel Sherrill, Ph.D.             Director of Research&  Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
    Support Available             (256) 722-9985





More information about the vc mailing list