change log for rtems (2010-06-15)

Sebastian Huber sebastian.huber at embedded-brains.de
Wed Jun 16 07:26:22 UTC 2010


On 06/15/2010 06:11 PM, rtems-vc at rtems.org wrote:
[...]
> diff -u rtems/cpukit/ChangeLog:1.2346.2.16 rtems/cpukit/ChangeLog:1.2346.2.17
> --- rtems/cpukit/ChangeLog:1.2346.2.16	Tue Jun 15 08:35:48 2010
> +++ rtems/cpukit/ChangeLog	Tue Jun 15 10:17:42 2010
> @@ -1,5 +1,6 @@
>  2010-06-15	Ralf Corsépius <ralf.corsepius at rtems.org>
>  
> +	* libfs/src/rfs/rtems-rfs-file-system.h: Remove bogus typecast.
>  	* libfs/src/rfs/rtems-rfs-block.c, libfs/src/rfs/rtems-rfs-buffer.c,
>  	libnetworking/nfs/bootp_subr.c: Misc. 64bit-compatibility fixes.
>  	* posix/include/rtems/posix/pthread.h: Remove stray comment.
> 
> diff -u rtems/cpukit/libfs/src/rfs/rtems-rfs-file-system.h:1.3 rtems/cpukit/libfs/src/rfs/rtems-rfs-file-system.h:1.4
> --- rtems/cpukit/libfs/src/rfs/rtems-rfs-file-system.h:1.3	Thu Feb 25 23:54:59 2010
> +++ rtems/cpukit/libfs/src/rfs/rtems-rfs-file-system.h	Tue Jun 15 10:17:35 2010
> @@ -308,7 +308,7 @@
>   *
>   * @param _fs Pointer to the file system.
>   */
> -#define rtems_rfs_fs_size(_fs) (((uint64_t) rtems_rfs_fs_blocks (_fs)) * \
> +#define rtems_rfs_fs_size(_fs) (rtems_rfs_fs_blocks (_fs) * \
>                                  rtems_rfs_fs_block_size (_fs))
>  
>  /**
> 
[...]

The blocks and block_size fields are of type size_t, thus I don't think that
this type cast is bogus.

Since size_t may have only 16-bits on some architectures we should consider to
use uint32_t for these fields.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the vc mailing list