change log for rtems (2010-06-24)

Joel Sherrill joel.sherrill at OARcorp.com
Fri Jun 25 12:09:23 UTC 2010


On 06/25/2010 02:02 AM, Sebastian Huber wrote:
> On 06/25/2010 12:12 AM, rtems-vc at rtems.org wrote:
> [...]
>    
>> diff -u rtems/cpukit/ChangeLog:1.2458 rtems/cpukit/ChangeLog:1.2459
>> --- rtems/cpukit/ChangeLog:1.2458	Thu Jun 24 16:27:29 2010
>> +++ rtems/cpukit/ChangeLog	Thu Jun 24 16:31:20 2010
>> @@ -1,3 +1,12 @@
>> +2010-06-24	Joel Sherrill<joel.sherrilL at OARcorp.com>
>> +
>> +	* libfs/src/imfs/imfs_creat.c, libfs/src/imfs/imfs_debug.c,
>> +	libfs/src/imfs/imfs_directory.c, libfs/src/imfs/imfs_eval.c,
>> +	libfs/src/imfs/imfs_fsunmount.c, libfs/src/imfs/imfs_getchild.c,
>> +	libfs/src/imfs/imfs_initsupp.c, libfs/src/imfs/ioman.c,
>> +	libfs/src/imfs/memfile.c: Evaluate all assert calls in IMFS. Either
>> +	made them conditional on RTEMS_DEBUG or eliminated them.
>> +
>>   2010-06-24	Gedare Bloom<giddyup44 at yahoo.com>
>>
>>   	PR 1590/cpukit
>>
>> diff -u rtems/cpukit/libfs/src/imfs/imfs_creat.c:1.15 rtems/cpukit/libfs/src/imfs/imfs_creat.c:1.16
>> --- rtems/cpukit/libfs/src/imfs/imfs_creat.c:1.15	Tue Jun  8 10:15:31 2010
>> +++ rtems/cpukit/libfs/src/imfs/imfs_creat.c	Thu Jun 24 16:31:21 2010
>> @@ -17,7 +17,9 @@
>>   #include "config.h"
>>   #endif
>>
>> -#include<assert.h>
>> +#if defined(RTEMS_DEBUG)
>> +  #include<assert.h>
>> +#endif
>>   #include<stdlib.h>
>>   #include<string.h>
>>   #include "imfs.h"
>> @@ -99,8 +101,10 @@
>>         break;
>>
>>       default:
>> -      assert(0);
>> -      break;
>> +      #if defined(RTEMS_DEBUG)
>> +        assert(0);
>> +      #endif
>> +      return;
>>     }
>>
>>     /*
>>
>>      
> I don't think that this explosion of ifdef is good.  Why not add a
> rtems_assert() which is defined in case of RTEMS_DEBUG?
>
>    
I was considering that as a separate sweep.

There are some NULL checks at the interface level to
the Score which should be assert's.

I will look at this in a future assert pass.

--joel



More information about the vc mailing list