change log for rtems (2010-11-04)
rtems-vc at rtems.org
rtems-vc at rtems.org
Thu Nov 4 23:11:14 UTC 2010
*joel*:
2010-11-04 Joel Sherrill <joel.sherrill at oarcorp.com>
* libmisc/stackchk/check.c: Address casting issue highlighted by clang.
There was no need for an intermediate cast to a structure pointer.
M 1.2641 cpukit/ChangeLog
M 1.73 cpukit/libmisc/stackchk/check.c
diff -u rtems/cpukit/ChangeLog:1.2640 rtems/cpukit/ChangeLog:1.2641
--- rtems/cpukit/ChangeLog:1.2640 Mon Nov 1 12:32:52 2010
+++ rtems/cpukit/ChangeLog Thu Nov 4 17:22:48 2010
@@ -1,3 +1,8 @@
+2010-11-04 Joel Sherrill <joel.sherrill at oarcorp.com>
+
+ * libmisc/stackchk/check.c: Address casting issue highlighted by clang.
+ There was no need for an intermediate cast to a structure pointer.
+
2010-11-01 Alin Rus <alin.codejunkie at gmail.com>
* posix/include/rtems/posix/aio_misc.h, posix/src/aio_misc.c: Small
diff -u rtems/cpukit/libmisc/stackchk/check.c:1.72 rtems/cpukit/libmisc/stackchk/check.c:1.73
--- rtems/cpukit/libmisc/stackchk/check.c:1.72 Wed Aug 25 15:29:41 2010
+++ rtems/cpukit/libmisc/stackchk/check.c Thu Nov 4 17:22:49 2010
@@ -79,8 +79,8 @@
* whether the stack grow to the high or low area of the memory.
*/
#if (CPU_STACK_GROWS_UP == TRUE)
- #define Stack_check_Get_pattern_area( _the_stack ) \
- ((Stack_check_Control *) ((char *)(_the_stack)->area + \
+ #define Stack_check_Get_pattern( _the_stack ) \
+ ((char *)(_the_stack)->area + \
(_the_stack)->size - sizeof( Stack_check_Control ) ))
#define Stack_check_Calculate_used( _low, _size, _high_water ) \
@@ -96,8 +96,8 @@
* The task stack free operation will write the next and previous pointers
* for the free list into this area.
*/
- #define Stack_check_Get_pattern_area( _the_stack ) \
- ((Stack_check_Control *) ((char *)(_the_stack)->area \
+ #define Stack_check_Get_pattern( _the_stack ) \
+ ((char *)(_the_stack)->area \
+ sizeof(Heap_Block) - HEAP_BLOCK_HEADER_SIZE))
#define Stack_check_Calculate_used( _low, _size, _high_water) \
@@ -109,6 +109,12 @@
#endif
/*
+ * Obtain a properly typed pointer to the area to check.
+ */
+#define Stack_check_Get_pattern_area( _the_stack ) \
+ ((Stack_check_Control *) Stack_check_Get_pattern( _the_stack )
+
+/*
* The assumption is that if the pattern gets overwritten, the task
* is too close. This defines the usable stack memory.
*/
@@ -219,8 +225,8 @@
void Stack_check_report_blown_task(Thread_Control *running, bool pattern_ok)
{
Stack_Control *stack = &running->Start.Initial_stack;
- void *pattern_area = Stack_check_Get_pattern_area(stack);
- char name [32];
+ void *pattern_area = Stack_check_Get_pattern(stack);
+ char name[32];
printk("BLOWN STACK!!!\n");
printk("task control block: 0x%08" PRIxPTR "\n", running);
@@ -270,10 +276,10 @@
{
Stack_Control *the_stack = &running->Start.Initial_stack;
void *pattern;
- bool sp_ok;
- bool pattern_ok = true;
+ bool sp_ok;
+ bool pattern_ok = true;
- pattern = (void *) Stack_check_Get_pattern_area(the_stack)->pattern;
+ pattern = Stack_check_Get_pattern_area(the_stack);
/*
* Check for an out of bounds stack pointer or an overwrite
@@ -309,7 +315,7 @@
*/
if ( Stack_check_Initialized ) {
pattern_ok = (!memcmp(
- (void *) Stack_check_Get_pattern_area(the_stack)->pattern,
+ Stack_check_Get_pattern(the_stack),
(void *) Stack_check_Pattern.pattern,
PATTERN_SIZE_BYTES
));
*joel*:
2010-11-04 Joel Sherrill <joel.sherrill at oarcorp.com>
* libmisc/stackchk/check.c: Make compile again.
* sapi/src/io.c, score/src/heap.c: Address dead assignment
issues found by clang.
M 1.2642 cpukit/ChangeLog
M 1.74 cpukit/libmisc/stackchk/check.c
M 1.32 cpukit/sapi/src/io.c
M 1.40 cpukit/score/src/heap.c
diff -u rtems/cpukit/ChangeLog:1.2641 rtems/cpukit/ChangeLog:1.2642
--- rtems/cpukit/ChangeLog:1.2641 Thu Nov 4 17:22:48 2010
+++ rtems/cpukit/ChangeLog Thu Nov 4 18:00:04 2010
@@ -1,5 +1,11 @@
2010-11-04 Joel Sherrill <joel.sherrill at oarcorp.com>
+ * libmisc/stackchk/check.c: Make compile again.
+ * sapi/src/io.c, score/src/heap.c: Address dead assignment
+ issues found by clang.
+
+2010-11-04 Joel Sherrill <joel.sherrill at oarcorp.com>
+
* libmisc/stackchk/check.c: Address casting issue highlighted by clang.
There was no need for an intermediate cast to a structure pointer.
diff -u rtems/cpukit/libmisc/stackchk/check.c:1.73 rtems/cpukit/libmisc/stackchk/check.c:1.74
--- rtems/cpukit/libmisc/stackchk/check.c:1.73 Thu Nov 4 17:22:49 2010
+++ rtems/cpukit/libmisc/stackchk/check.c Thu Nov 4 18:00:04 2010
@@ -81,7 +81,7 @@
#if (CPU_STACK_GROWS_UP == TRUE)
#define Stack_check_Get_pattern( _the_stack ) \
((char *)(_the_stack)->area + \
- (_the_stack)->size - sizeof( Stack_check_Control ) ))
+ (_the_stack)->size - sizeof( Stack_check_Control ) )
#define Stack_check_Calculate_used( _low, _size, _high_water ) \
((char *)(_high_water) - (char *)(_low))
@@ -97,8 +97,7 @@
* for the free list into this area.
*/
#define Stack_check_Get_pattern( _the_stack ) \
- ((char *)(_the_stack)->area \
- + sizeof(Heap_Block) - HEAP_BLOCK_HEADER_SIZE))
+ ((char *)(_the_stack)->area + sizeof(Heap_Block) - HEAP_BLOCK_HEADER_SIZE)
#define Stack_check_Calculate_used( _low, _size, _high_water) \
( ((char *)(_low) + (_size)) - (char *)(_high_water) )
@@ -112,7 +111,7 @@
* Obtain a properly typed pointer to the area to check.
*/
#define Stack_check_Get_pattern_area( _the_stack ) \
- ((Stack_check_Control *) Stack_check_Get_pattern( _the_stack )
+ (Stack_check_Control *) Stack_check_Get_pattern( _the_stack )
/*
* The assumption is that if the pattern gets overwritten, the task
diff -u rtems/cpukit/sapi/src/io.c:1.31 rtems/cpukit/sapi/src/io.c:1.32
--- rtems/cpukit/sapi/src/io.c:1.31 Sun Nov 29 07:51:52 2009
+++ rtems/cpukit/sapi/src/io.c Thu Nov 4 18:00:04 2010
@@ -80,7 +80,6 @@
for ( index = 0 ; index < drivers_in_table ; index++ )
_IO_Driver_address_table[index] = driver_table[index];
- number_of_drivers = drivers_in_table;
}
/*
diff -u rtems/cpukit/score/src/heap.c:1.39 rtems/cpukit/score/src/heap.c:1.40
--- rtems/cpukit/score/src/heap.c:1.39 Wed Aug 25 07:35:52 2010
+++ rtems/cpukit/score/src/heap.c Thu Nov 4 18:00:04 2010
@@ -416,7 +416,6 @@
uintptr_t const prev_block_size = _Heap_Block_size( prev_block );
block = prev_block;
- block_begin = (uintptr_t) block;
block_size += prev_block_size;
}
--
Generated by Deluxe Loginfo [http://www.codewiz.org/projects/index.html#loginfo] 2.122 by Bernardo Innocenti <bernie at develer.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/vc/attachments/20101104/7b5ff0ed/attachment.html>
More information about the vc
mailing list