change log for rtems (2011-04-15)

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Apr 15 13:22:47 UTC 2011


On 04/15/2011 03:19 PM, Joel Sherrill wrote:
> On 04/15/2011 07:51 AM, Sebastian Huber wrote:
>> On 04/15/2011 02:43 PM, Joel Sherrill wrote:
>>> The change to the test code is wrong. All rtems_ methods in it return
>>> rtems_status_code not int. If there is a mix or return types use two
>>> variables.
>> Do you refer to psxstat?  In test.c the status variable must be of
>> type int.
>> The return value of the rtems_* methods is ignored (it was an assignment
>> without effect).
>>
> I was reviewing on my phone so it was a bit difficult.
> The code I was referring to had taken the status =
> off of rtems_ calls.

Yes, that were the assignments without effect.  Should I add an

rtems_test_assert( status == RTEMS_SUCCESSFUL )

?

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the vc mailing list