change log for rtems (2011-08-16)
Sebastian Huber
sebastian.huber at embedded-brains.de
Wed Aug 17 09:13:01 UTC 2011
On 08/17/2011 10:35 AM, Ralf Corsepius wrote:
> On 08/17/2011 09:34 AM, Sebastian Huber wrote:
>> On 08/17/2011 01:11 AM, Chris Johns wrote:
>>> On 16/08/11 10:10 PM, rtems-vc at rtems.org wrote:
>>>>
>>>> +#include<bsp.h>
>>>> +
>>>
>>> Does this work with --enable-multilib ?
>
> It doesn't matter.
>
> cpukit files must not include or depend on bsp include-files.
Ok, the confdefs.h is included in libmisc/dummy/dummy.c, so the change violates
this rule.
>
>> I don't know, but can I build an application without a BSP? Header files
>> that depend on previous includes are work of the devil.
>
> IMO, this patch needs to be reverted.
>
> Ralf
Ok, I revert it.
I still think it is pretty bad that confdefs.h uses the defines
BSP_IDLE_TASK_BODY, BSP_IDLE_TASK_STACK_SIZE, BSP_INTERRUPT_STACK_SIZE,
BSP_ZERO_WORKSPACE_AUTOMATICALLY, BSP_DEFAULT_UNIFIED_WORK_AREAS,
CONFIGURE_MALLOC_BSP_SUPPORTS_SBRK, and CONFIGURE_BSP_PREREQUISITE_DRIVERS
without including <bsp.h>. Maybe we should move confdefs.h and dummy.c out of
the cpukit.
--
Sebastian Huber, embedded brains GmbH
Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone : +49 89 18 90 80 79-6
Fax : +49 89 18 90 80 79-9
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
More information about the vc
mailing list