change log for rtems (2011-07-19)

rtems-vc at rtems.org rtems-vc at rtems.org
Tue Jul 19 14:10:16 UTC 2011


 *joel*:
2011-07-19	Joel Sherrill <joel.sherrilL at OARcorp.com>

	PR 1838/filesystem
	* psxfchx01/init.c, psxfchx01/psxfchx01.scn: fchmod() does not need a
	writeable file descriptor.

M  1.345  testsuites/psxtests/ChangeLog
M    1.3  testsuites/psxtests/psxfchx01/init.c
M    1.2  testsuites/psxtests/psxfchx01/psxfchx01.scn

diff -u rtems/testsuites/psxtests/ChangeLog:1.344 rtems/testsuites/psxtests/ChangeLog:1.345
--- rtems/testsuites/psxtests/ChangeLog:1.344	Mon Jun 20 00:51:51 2011
+++ rtems/testsuites/psxtests/ChangeLog	Tue Jul 19 08:10:46 2011
@@ -1,3 +1,9 @@
+2011-07-19	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1838/filesystem
+	* psxfchx01/init.c, psxfchx01/psxfchx01.scn: fchmod() does not need a
+	writeable file descriptor.
+
 2011-06-20	Ralf Corsépius <ralf.corsepius at rtems.org>
 
 	* psxautoinit01/Makefile.am, psxautoinit02/Makefile.am,

diff -u rtems/testsuites/psxtests/psxfchx01/init.c:1.2 rtems/testsuites/psxtests/psxfchx01/init.c:1.3
--- rtems/testsuites/psxtests/psxfchx01/init.c:1.2	Tue Feb 22 03:47:32 2011
+++ rtems/testsuites/psxtests/psxfchx01/init.c	Tue Jul 19 08:10:46 2011
@@ -1,5 +1,5 @@
 /*
- *  COPYRIGHT (c) 1989-2010.
+ *  COPYRIGHT (c) 1989-2011.
  *  On-Line Applications Research Corporation (OAR).
  *
  *  The license and distribution terms for this file may be
@@ -55,7 +55,7 @@
   rtems_test_assert( status == -1 );
   rtems_test_assert( errno == EINVAL );
 
-  puts(" Init - closing /newfile -- OK" );
+  puts( "Init - closing /newfile -- OK" );
   status = close( fd );
   rtems_test_assert( status == 0 );
 
@@ -140,12 +140,11 @@
   fd = open( "/newfile", O_RDONLY | O_CREAT, S_IRWXU );
   rtems_test_assert( fd != -1 );
   
-  puts( "Init - fchmod, with the opened file descriptor - expect EINVAL" );
+  puts( "Init - fchmod, with the opened file descriptor -- OK" );
   status = fchmod( fd, 0 );
-  rtems_test_assert( status == -1 );
-  rtems_test_assert( errno == EINVAL );
+  rtems_test_assert( status == 0 );
 
-  puts(" Init - close and remove /newfile" );
+  puts( "Init - close and remove /newfile" );
   status = close( fd );
   status |= unlink( "/newfile" );
   rtems_test_assert( status == 0 );
@@ -158,7 +157,7 @@
   status = fchmod( fd, S_IRUSR );
   rtems_test_assert( status == 0 );
 
-  puts(" Init - close and remove /newfile -- OK" );
+  puts( "Init - close and remove /newfile -- OK" );
   status = close( fd );
   status |= unlink( "/newfile" );
   rtems_test_assert( status == 0 );
@@ -190,7 +189,7 @@
   rtems_test_assert( status == -1 );
   rtems_test_assert( errno == EINVAL );
 
-  puts(" Init - close and remove /newfile" );
+  puts( "Init - close and remove /newfile" );
   status = close( fd );
   status |= unlink( "/newfile" );
   rtems_test_assert( status == 0 );
@@ -203,7 +202,7 @@
   status = fchown( fd, 1, 0 );
   rtems_test_assert( status == 0 );
 
-  puts(" Init - close and remove /newfile -- OK" );
+  puts( "Init - close and remove /newfile -- OK" );
   status = close( fd );
   status |= unlink( "/newfile" );
   rtems_test_assert( status == 0 );

diff -u rtems/testsuites/psxtests/psxfchx01/psxfchx01.scn:1.1 rtems/testsuites/psxtests/psxfchx01/psxfchx01.scn:1.2
--- rtems/testsuites/psxtests/psxfchx01/psxfchx01.scn:1.1	Tue Jul 13 16:13:12 2010
+++ rtems/testsuites/psxtests/psxfchx01/psxfchx01.scn	Tue Jul 19 08:10:46 2011
@@ -4,7 +4,7 @@
 Init - Attempt fchdir with bad file descriptor - expect EBADF
 Init - opening /newfile in write-mode -- OK
 Init - fchdir on the file descriptor - expect EINVAL
- Init - closing /newfile -- OK
+Init - closing /newfile -- OK
 Init - removing /newfile -- OK
 Init - opening /newfile in read-mode -- OK
 Init - fchdir on the file descriptor - expect ENOTDIR
@@ -25,11 +25,11 @@
 Init - fchmod, with a bad file descriptor - expect EBADF
 Init - fchmod, with an unopened file descriptor - expect EBADF
 Init - open new file: /newfile in read-only mode -- OK
-Init - fchmod, with the opened file descriptor - expect EINVAL
- Init - close and remove /newfile
+Init - fchmod, with the opened file descriptor -- OK
+Init - close and remove /newfile
 Init - open new file: /newfile in read-write mode -- OK
 Init - fchmod, with the opened file descriptor -- OK
- Init - close and remove /newfile -- OK
+Init - close and remove /newfile -- OK
 End of fchmod tests
 
 Init - fchown tests
@@ -37,9 +37,9 @@
 Init - fchown, with an unopened file descriptor - expect EBADF
 Init - open new file: /newfile in read-only mode -- OK
 Init - fchown, with the opened file descriptor - expect EINVAL
- Init - close and remove /newfile
+Init - close and remove /newfile
 Init - open new file: /newfile in read-write mode -- OK
 Init - fchown, with the opened file descriptor -- OK
- Init - close and remove /newfile -- OK
+Init - close and remove /newfile -- OK
 End of fchown tests
 *** END OF TEST Posix file op tests - 01 ***


 *joel* (on branch rtems-4-9-branch):
2011-07-19	Joel Sherrill <joel.sherrilL at OARcorp.com>

	PR 1838/filesystem
	* libcsupport/src/fchmod.c: fchmod() does not need a writeable file
	descriptor.

M 1.2881  cpukit/ChangeLog
M 1.1539.2.77  cpukit/ChangeLog
M 1.2346.2.98  cpukit/ChangeLog
M   1.14  cpukit/libcsupport/src/fchmod.c
M 1.12.8.1  cpukit/libcsupport/src/fchmod.c
M 1.12.6.1  cpukit/libcsupport/src/fchmod.c

diff -u rtems/cpukit/ChangeLog:1.2880 rtems/cpukit/ChangeLog:1.2881
--- rtems/cpukit/ChangeLog:1.2880	Tue Jul 19 07:19:05 2011
+++ rtems/cpukit/ChangeLog	Tue Jul 19 08:10:30 2011
@@ -1,3 +1,9 @@
+2011-07-19	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1838/filesystem
+	* libcsupport/src/fchmod.c: fchmod() does not need a writeable file
+	descriptor.
+
 2011-07-19	Sebastian Huber <sebastian.huber at embedded-brains.de>
 
 	* rtems/src/msgqcreate.c: Make packet size check consistent with

diff -u rtems/cpukit/ChangeLog:1.1539.2.76 rtems/cpukit/ChangeLog:1.1539.2.77
--- rtems/cpukit/ChangeLog:1.1539.2.76	Thu Jul 14 14:21:46 2011
+++ rtems/cpukit/ChangeLog	Tue Jul 19 08:14:16 2011
@@ -1,3 +1,9 @@
+2011-07-19	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1838/filesystem
+	* libcsupport/src/fchmod.c: fchmod() does not need a writeable file
+	descriptor.
+
 2011-07-14      Gene Smith <gene.smith at siemens.com>
 
 	PR 1381/networking

diff -u rtems/cpukit/ChangeLog:1.2346.2.97 rtems/cpukit/ChangeLog:1.2346.2.98
--- rtems/cpukit/ChangeLog:1.2346.2.97	Thu Jul 14 14:22:04 2011
+++ rtems/cpukit/ChangeLog	Tue Jul 19 08:14:07 2011
@@ -1,3 +1,9 @@
+2011-07-19	Joel Sherrill <joel.sherrilL at OARcorp.com>
+
+	PR 1838/filesystem
+	* libcsupport/src/fchmod.c: fchmod() does not need a writeable file
+	descriptor.
+
 2011-07-14      Gene Smith <gene.smith at siemens.com>
 
 	PR 1381/networking

diff -u rtems/cpukit/libcsupport/src/fchmod.c:1.13 rtems/cpukit/libcsupport/src/fchmod.c:1.14
--- rtems/cpukit/libcsupport/src/fchmod.c:1.13	Thu Jul  1 10:12:36 2010
+++ rtems/cpukit/libcsupport/src/fchmod.c	Tue Jul 19 08:10:31 2011
@@ -1,7 +1,7 @@
 /*
  *  fchmod() - POSIX 1003.1b 5.6.4 - Change File Modes
  *
- *  COPYRIGHT (c) 1989-1999.
+ *  COPYRIGHT (c) 1989-2011.
  *  On-Line Applications Research Corporation (OAR).
  *
  *  The license and distribution terms for this file may be
@@ -38,8 +38,5 @@
   /*
    *  Now process the fchmod().
    */
-
-  rtems_libio_check_permissions( iop, LIBIO_FLAGS_WRITE );
-
   return (*iop->pathinfo.handlers->fchmod_h)( &iop->pathinfo, mode );
 }

diff -u rtems/cpukit/libcsupport/src/fchmod.c:1.12 rtems/cpukit/libcsupport/src/fchmod.c:1.12.8.1
--- rtems/cpukit/libcsupport/src/fchmod.c:1.12	Sun Apr 18 01:05:34 2004
+++ rtems/cpukit/libcsupport/src/fchmod.c	Tue Jul 19 08:14:09 2011
@@ -1,7 +1,7 @@
 /*
  *  fchmod() - POSIX 1003.1b 5.6.4 - Change File Modes
  *
- *  COPYRIGHT (c) 1989-1999.
+ *  COPYRIGHT (c) 1989-2011.
  *  On-Line Applications Research Corporation (OAR).
  *
  *  The license and distribution terms for this file may be
@@ -38,9 +38,6 @@
   /*
    *  Now process the fchmod().
    */
-
-  rtems_libio_check_permissions( iop, LIBIO_FLAGS_WRITE );
-
   if ( !iop->handlers->fchmod_h )
     rtems_set_errno_and_return_minus_one( ENOTSUP );
 

diff -u rtems/cpukit/libcsupport/src/fchmod.c:1.12 rtems/cpukit/libcsupport/src/fchmod.c:1.12.6.1
--- rtems/cpukit/libcsupport/src/fchmod.c:1.12	Sun Apr 18 01:05:34 2004
+++ rtems/cpukit/libcsupport/src/fchmod.c	Tue Jul 19 08:14:18 2011
@@ -38,9 +38,6 @@
   /*
    *  Now process the fchmod().
    */
-
-  rtems_libio_check_permissions( iop, LIBIO_FLAGS_WRITE );
-
   if ( !iop->handlers->fchmod_h )
     rtems_set_errno_and_return_minus_one( ENOTSUP );
 



--

Generated by Deluxe Loginfo [http://www.codewiz.org/projects/index.html#loginfo] 2.122 by Bernardo Innocenti <bernie at develer.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/vc/attachments/20110719/3cfcb369/attachment-0001.html>


More information about the vc mailing list