change log for rtems (2011-03-18)

[Sebastian Huber]

On 03/18/2011 04:10 PM, rtems-vc at rtems.org wrote:
>  *jennifer*
> 
> All possible cpus must be initialized prior to determining how many are actually used.
> 
> M
> <http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/ChangeLog.diff?r1=text&tr1=1.2785&r2=text&tr2=1.2786&diff_format=h>
> 1.2786	cpukit/ChangeLog
> M
> <http://www.rtems.com/cgi-bin/viewcvs.cgi//rtems/cpukit/score/src/percpu.c.diff?r1=text&tr1=1.2&r2=text&tr2=1.3&diff_format=h>
> 1.3	cpukit/score/src/percpu.c
> 
> diff -u rtems/cpukit/ChangeLog:1.2785 rtems/cpukit/ChangeLog:1.2786
> --- rtems/cpukit/ChangeLog:1.2785	Wed Mar 16 15:05:03 2011
> +++ rtems/cpukit/ChangeLog	Fri Mar 18 09:12:46 2011
> @@ -1,3 +1,8 @@
> +2011-03-18	Jennifer Averett <Jennifer.Averett at OARcorp.com>
> +
> +	* score/src/percpu.c: All possible cpus must be
> +	initialized prior to determining how many are actually used.
> +
>  2011-03-16	Jennifer Averett <jennifer.averett at OARcorp.com>
>  
>  	PR 1729/cpukit
> 
> diff -u rtems/cpukit/score/src/percpu.c:1.2 rtems/cpukit/score/src/percpu.c:1.3
> --- rtems/cpukit/score/src/percpu.c:1.2	Wed Mar 16 15:05:06 2011
> +++ rtems/cpukit/score/src/percpu.c	Fri Mar 18 09:12:46 2011
> @@ -40,7 +40,10 @@
>       */
>      size = Configuration.interrupt_stack_size;
>      _Per_CPU_Information_p[0] = &_Per_CPU_Information[0];
> -    for (cpu=1 ; cpu < _SMP_Processor_count ; cpu++ ) {
> +    for (cpu=1 ; cpu < rtems_smp_maximum_processors; cpu++ ) {
> +
> +      printk("Initializing cpu control structure %d\n", cpu );
> +
>        Per_CPU_Control *p = &_Per_CPU_Information[cpu];
>  
>        _Per_CPU_Information_p[cpu] = p;

This is quite a hack.  This _SMP_Processor_count replacement is a clear name
space violation.  Where else do you see rtems_* stuff in the score?  printk()
should be anathema inside the score (except if debugging is enabled).

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.