change log for rtems (2011-11-07)

Sebastian Huber sebastian.huber at embedded-brains.de
Tue Nov 8 10:53:56 UTC 2011


On 11/07/2011 07:18 PM, Ralf Corsepius wrote:
> On 11/07/2011 10:10 AM, rtems-vc at rtems.org wrote:
>
>> diff -u rtems/c/src/lib/libbsp/arm/lpc24xx/console/console-config.c:1.7
>> rtems/c/src/lib/libbsp/arm/lpc24xx/console/console-config.c:1.8
>> --- rtems/c/src/lib/libbsp/arm/lpc24xx/console/console-config.c:1.7 Tue Oct
>> 18 13:25:35 2011
>> +++ rtems/c/src/lib/libbsp/arm/lpc24xx/console/console-config.c Mon Nov 7
>> 02:33:14 2011
>> @@ -177,5 +177,6 @@
>> };
>>
>> #define LPC24XX_UART_COUNT \
>> - (sizeof(Console_Configuration_Ports) / sizeof(console_tbl))
>> + (sizeof(Console_Configuration_Ports) \
>> + / sizeof(Console_Configuration_Ports [0]))
>> unsigned long Console_Configuration_Count = LPC24XX_UART_COUNT;
>
> Minor nit: This should be size_t instead of long, because the size of a
> division of sizes is of type size_t.

Yes, this should be size_t, but there are so many broken integer types within 
the console/Termios stuff that it is not worth to fix this alone.

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the vc mailing list