change log for rtems (2011-09-02)

Ralf Corsepius ralf.corsepius at rtems.org
Fri Sep 2 08:20:04 UTC 2011


On 09/02/2011 10:10 AM, rtems-vc at rtems.org wrote:
> *sh*
>
> 2011-09-02	Sebastian Huber<sebastian.huber at embedded-brains.de>

> diff -u rtems/cpukit/score/cpu/nios2/rtems/score/nios2-utility.h:1.1 rtems/cpukit/score/cpu/nios2/rtems/score/nios2-utility.h:1.2
> --- rtems/cpukit/score/cpu/nios2/rtems/score/nios2-utility.h:1.1	Thu Sep  1 10:52:12 2011
> +++ rtems/cpukit/score/cpu/nios2/rtems/score/nios2-utility.h	Fri Sep  2 02:52:30 2011
> @@ -103,16 +103,36 @@
>   #define NIOS2_MPUBASE_BASE_OFFSET 5
>   #define NIOS2_MPUBASE_BASE_MASK (0x1ffffff<<  NIOS2_MPUBASE_BASE_OFFSET)
>   #define NIOS2_MPUBASE_INDEX_OFFSET 1
> -#define NIOS2_MPUBASE_INDEX_MASK (0x1f<<  NIOS2_MPUBASE_INDEX_OFFSET)
> +
> +/* Avoid redefines with Altera HAL */
> +#ifndef NIOS2_MPUBASE_INDEX_MASK
> +  #define NIOS2_MPUBASE_INDEX_MASK (0x1f<<  NIOS2_MPUBASE_INDEX_OFFSET)
> +#endif

This is unsafe and poor design. These redefines are a way guaranteed to 
end up in havoc.

Ralf




More information about the vc mailing list