[rtems commit] fstests/fsimfsgeneric01: Avoid global state

Sebastian Huber sebh at rtems.org
Sun Oct 7 15:17:49 UTC 2012


Module:    rtems
Branch:    master
Commit:    39d7d51fe3c466816d70184da06b957d6c8fdbcc
Changeset: http://git.rtems.org/rtems/commit/?id=39d7d51fe3c466816d70184da06b957d6c8fdbcc

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Sun Oct  7 17:11:30 2012 +0200

fstests/fsimfsgeneric01: Avoid global state

---

 testsuites/fstests/fsimfsgeneric01/init.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/testsuites/fstests/fsimfsgeneric01/init.c b/testsuites/fstests/fsimfsgeneric01/init.c
index 1a25dec..482821a 100644
--- a/testsuites/fstests/fsimfsgeneric01/init.c
+++ b/testsuites/fstests/fsimfsgeneric01/init.c
@@ -46,8 +46,6 @@ typedef enum {
   TEST_DESTROYED
 } test_state;
 
-static test_state global_state = TEST_NEW;
-
 static int handler_open(
   rtems_libio_t *iop,
   const char *path,
@@ -263,6 +261,7 @@ static const IMFS_node_control node_control = {
 
 static void test_imfs_make_generic_node(void)
 {
+  test_state state = TEST_NEW;
   int rv = 0;
   int fd = 0;
   const char *path = "generic";
@@ -274,7 +273,7 @@ static void test_imfs_make_generic_node(void)
     path,
     S_IFCHR | S_IRWXU | S_IRWXG | S_IRWXO,
     &node_control,
-    &global_state
+    &state
   );
   rtems_test_assert(rv == 0);
 
@@ -311,7 +310,7 @@ static void test_imfs_make_generic_node(void)
   rv = unlink(path);
   rtems_test_assert(rv == 0);
 
-  rtems_test_assert(global_state == TEST_DESTROYED);
+  rtems_test_assert(state == TEST_DESTROYED);
 }
 
 static const IMFS_node_control node_invalid_control = {




More information about the vc mailing list