[rtems commit] sync.c: Add asserts to document and check assumptions
Joel Sherril
joel at rtems.org
Thu Nov 27 16:07:54 UTC 2014
Module: rtems
Branch: master
Commit: e22af784cd44cd407e268307ede01f6e1b621393
Changeset: http://git.rtems.org/rtems/commit/?id=e22af784cd44cd407e268307ede01f6e1b621393
Author: Joel Sherrill <joel.sherrill at oarcorp.com>
Date: Thu Nov 27 09:30:12 2014 -0600
sync.c: Add asserts to document and check assumptions
---
cpukit/libcsupport/src/sync.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/cpukit/libcsupport/src/sync.c b/cpukit/libcsupport/src/sync.c
index 653a177..f27349c 100644
--- a/cpukit/libcsupport/src/sync.c
+++ b/cpukit/libcsupport/src/sync.c
@@ -29,6 +29,7 @@ int fdatasync(int); /* still not always prototyped */
#include <stdio.h>
#include <rtems.h>
+#include <rtems/score/assert.h>
/* XXX check standards -- Linux version appears to be void */
void _fwalk(struct _reent *, void *);
@@ -37,14 +38,19 @@ void _fwalk(struct _reent *, void *);
static void sync_wrapper(FILE *f)
{
int fn = fileno(f);
+ int rc;
/*
- * We are explicitly NOT checking the return values as it does not
- * matter if they succeed. We are just making a best faith attempt
- * at both and trusting that we were passed a good FILE pointer.
+ * We are explicitly NOT checking the return values in non-debug builds
+ * as it does not matter if they succeed. We are just making a best
+ * faith attempt at both and trusting that we were passed a good
+ * FILE pointer.
*/
- fsync(fn);
- fdatasync(fn);
+ rc = fsync(fn);
+ _Assert( rc == 0 );
+
+ rc = fdatasync(fn);
+ _Assert( rc == 0 );
}
/* iterate over all FILE *'s for this thread */
More information about the vc
mailing list