[rtems commit] score: Delete bogus THREAD_QUEUE_WAIT_FOREVER

Sebastian Huber sebh at rtems.org
Wed Apr 22 09:40:03 UTC 2015


Module:    rtems
Branch:    master
Commit:    49d436497ed278f1d02b45c6f336a21c0b7ab93a
Changeset: http://git.rtems.org/rtems/commit/?id=49d436497ed278f1d02b45c6f336a21c0b7ab93a

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Wed Apr 22 11:35:14 2015 +0200

score: Delete bogus THREAD_QUEUE_WAIT_FOREVER

It makes no sense to use this indirection since the type for timeout
values is Watchdog_Interval.

---

 cpukit/posix/src/condwait.c                    | 2 +-
 cpukit/posix/src/mqueuereceive.c               | 2 +-
 cpukit/posix/src/mqueuesend.c                  | 2 +-
 cpukit/posix/src/mutexlock.c                   | 2 +-
 cpukit/posix/src/mutextrylock.c                | 2 +-
 cpukit/posix/src/semtrywait.c                  | 2 +-
 cpukit/posix/src/semwait.c                     | 2 +-
 cpukit/score/include/rtems/score/threadqimpl.h | 5 -----
 8 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/cpukit/posix/src/condwait.c b/cpukit/posix/src/condwait.c
index 79ecc2e..034b914 100644
--- a/cpukit/posix/src/condwait.c
+++ b/cpukit/posix/src/condwait.c
@@ -39,7 +39,7 @@ int pthread_cond_wait(
   return _POSIX_Condition_variables_Wait_support(
     cond,
     mutex,
-    THREAD_QUEUE_WAIT_FOREVER,
+    WATCHDOG_NO_TIMEOUT,
     false
   );
 }
diff --git a/cpukit/posix/src/mqueuereceive.c b/cpukit/posix/src/mqueuereceive.c
index 6c283fd..493ac79 100644
--- a/cpukit/posix/src/mqueuereceive.c
+++ b/cpukit/posix/src/mqueuereceive.c
@@ -45,6 +45,6 @@ ssize_t mq_receive(
     msg_len,
     msg_prio,
     true,
-    THREAD_QUEUE_WAIT_FOREVER
+    WATCHDOG_NO_TIMEOUT
   );
 }
diff --git a/cpukit/posix/src/mqueuesend.c b/cpukit/posix/src/mqueuesend.c
index 6dc0f10..01ea896 100644
--- a/cpukit/posix/src/mqueuesend.c
+++ b/cpukit/posix/src/mqueuesend.c
@@ -63,6 +63,6 @@ int mq_send(
     msg_len,
     msg_prio,
     true,
-    THREAD_QUEUE_WAIT_FOREVER
+    WATCHDOG_NO_TIMEOUT
   );
 }
diff --git a/cpukit/posix/src/mutexlock.c b/cpukit/posix/src/mutexlock.c
index cc8ffc2..43114fd 100644
--- a/cpukit/posix/src/mutexlock.c
+++ b/cpukit/posix/src/mutexlock.c
@@ -38,5 +38,5 @@ int pthread_mutex_lock(
   pthread_mutex_t           *mutex
 )
 {
-  return _POSIX_Mutex_Lock_support( mutex, true, THREAD_QUEUE_WAIT_FOREVER );
+  return _POSIX_Mutex_Lock_support( mutex, true, WATCHDOG_NO_TIMEOUT );
 }
diff --git a/cpukit/posix/src/mutextrylock.c b/cpukit/posix/src/mutextrylock.c
index 332f486..e765e91 100644
--- a/cpukit/posix/src/mutextrylock.c
+++ b/cpukit/posix/src/mutextrylock.c
@@ -37,7 +37,7 @@ int pthread_mutex_trylock(
   pthread_mutex_t           *mutex
 )
 {
-  int r = _POSIX_Mutex_Lock_support( mutex, false, THREAD_QUEUE_WAIT_FOREVER );
+  int r = _POSIX_Mutex_Lock_support( mutex, false, WATCHDOG_NO_TIMEOUT );
   if ( r == EDEADLK )
     r = EBUSY;
   return r;
diff --git a/cpukit/posix/src/semtrywait.c b/cpukit/posix/src/semtrywait.c
index 10b1f60..addc071 100644
--- a/cpukit/posix/src/semtrywait.c
+++ b/cpukit/posix/src/semtrywait.c
@@ -35,5 +35,5 @@ int sem_trywait(
   sem_t *sem
 )
 {
-  return _POSIX_Semaphore_Wait_support(sem, false, THREAD_QUEUE_WAIT_FOREVER);
+  return _POSIX_Semaphore_Wait_support(sem, false, WATCHDOG_NO_TIMEOUT);
 }
diff --git a/cpukit/posix/src/semwait.c b/cpukit/posix/src/semwait.c
index b2344f0..88324e5 100644
--- a/cpukit/posix/src/semwait.c
+++ b/cpukit/posix/src/semwait.c
@@ -35,5 +35,5 @@ int sem_wait(
   sem_t *sem
 )
 {
-  return _POSIX_Semaphore_Wait_support( sem, true, THREAD_QUEUE_WAIT_FOREVER );
+  return _POSIX_Semaphore_Wait_support( sem, true, WATCHDOG_NO_TIMEOUT );
 }
diff --git a/cpukit/score/include/rtems/score/threadqimpl.h b/cpukit/score/include/rtems/score/threadqimpl.h
index 4c8d22e..2fa7974 100644
--- a/cpukit/score/include/rtems/score/threadqimpl.h
+++ b/cpukit/score/include/rtems/score/threadqimpl.h
@@ -32,11 +32,6 @@ extern "C" {
 /**@{*/
 
 /**
- *  Constant for indefinite wait.
- */
-#define THREAD_QUEUE_WAIT_FOREVER  WATCHDOG_NO_TIMEOUT
-
-/**
  *  The following type defines the callout used when a remote task
  *  is extracted from a local thread queue.
  */




More information about the vc mailing list