[rtems commit] libcsupport: Fix umask() locking

Sebastian Huber sebh at rtems.org
Wed May 20 07:12:03 UTC 2015


Module:    rtems
Branch:    master
Commit:    4a3c920d307f9da19a4215f2496e8ddd9bddce15
Changeset: http://git.rtems.org/rtems/commit/?id=4a3c920d307f9da19a4215f2496e8ddd9bddce15

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Mon May  4 09:30:21 2015 +0200

libcsupport: Fix umask() locking

Delete comment related to an obsolete implementation of
rtems_libio_set_private_env().

---

 cpukit/libcsupport/src/umask.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/cpukit/libcsupport/src/umask.c b/cpukit/libcsupport/src/umask.c
index 678cac8..fba2405 100644
--- a/cpukit/libcsupport/src/umask.c
+++ b/cpukit/libcsupport/src/umask.c
@@ -21,7 +21,6 @@
 #include <sys/stat.h>
 
 #include <rtems/libio_.h>
-#include <rtems/score/threaddispatch.h>
 
 /**
  *  POSIX 1003.1b 5.3.3 - Set File Creation Mask
@@ -30,14 +29,10 @@ mode_t umask( mode_t cmask )
 {
   mode_t old_mask;
 
-  /*
-   * We must use the same protection mechanism as in
-   * rtems_libio_set_private_env().
-   */
-  _Thread_Disable_dispatch();
+  rtems_libio_lock();
   old_mask = rtems_filesystem_umask;
   rtems_filesystem_umask = cmask & (S_IRWXU | S_IRWXG | S_IRWXO);
-  _Thread_Enable_dispatch();
+  rtems_libio_unlock();
 
   return old_mask;
 }



More information about the vc mailing list