[rtems commit] nfsclient: Fix suspicious condition

Sebastian Huber sebh at rtems.org
Mon Jan 23 13:39:39 UTC 2017


Module:    rtems
Branch:    master
Commit:    c0151e6c6486ce3ae3623e616326fae626f32eb2
Changeset: http://git.rtems.org/rtems/commit/?id=c0151e6c6486ce3ae3623e616326fae626f32eb2

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Mon Jan 23 14:38:35 2017 +0100

nfsclient: Fix suspicious condition

Close #2700.

---

 cpukit/libfs/src/nfsclient/src/rpcio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cpukit/libfs/src/nfsclient/src/rpcio.c b/cpukit/libfs/src/nfsclient/src/rpcio.c
index 2848225..e038e73 100644
--- a/cpukit/libfs/src/nfsclient/src/rpcio.c
+++ b/cpukit/libfs/src/nfsclient/src/rpcio.c
@@ -521,7 +521,8 @@ struct pmap		pmaparg;
 		return RPC_UNKNOWNHOST;
 	}
 
-	if ( (len = getgroups(NGROUPS, gids) < 0 ) ) {
+	len = getgroups(NGROUPS, gids);
+	if (len < 0 ) {
 		fprintf(stderr,
 				"RPCIO - error: I unable to get group ids (%s)\n",
 				strerror(errno));



More information about the vc mailing list