[rtems commit] Do not include <sys/ioctl.h> in kernel-space

Sebastian Huber sebh at rtems.org
Wed Jun 7 13:26:58 UTC 2017


Module:    rtems
Branch:    master
Commit:    787f51f5b34083c246310bd80eaa93e5c539de76
Changeset: http://git.rtems.org/rtems/commit/?id=787f51f5b34083c246310bd80eaa93e5c539de76

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Tue Jun  6 11:08:16 2017 +0200

Do not include <sys/ioctl.h> in kernel-space

Update #2833.

---

 c/src/lib/libbsp/arm/atsam/network/if_atsam.c                    | 1 -
 c/src/lib/libbsp/powerpc/beatnik/network/if_gfe/if_gfe.c         | 2 +-
 c/src/lib/libbsp/powerpc/mpc8260ads/network/if_hdlcsubr.c        | 2 +-
 c/src/lib/libbsp/powerpc/mvme5500/network/if_100MHz/GT64260eth.c | 1 -
 c/src/lib/libbsp/powerpc/mvme5500/network/if_1GHz/if_wm.c        | 1 -
 c/src/libchip/network/i82586.c                                   | 1 -
 cpukit/libcsupport/include/rtems/libio.h                         | 2 +-
 cpukit/libcsupport/src/termios.c                                 | 1 +
 cpukit/libfs/src/imfs/imfs_fifo.c                                | 2 ++
 cpukit/libfs/src/pipe/fifo.c                                     | 1 +
 cpukit/libmisc/shell/main_ifconfig.c                             | 1 +
 cpukit/libnetworking/net/if.c                                    | 2 +-
 cpukit/libnetworking/net/if_ethersubr.c                          | 2 +-
 cpukit/libnetworking/net/if_loop.c                               | 2 +-
 cpukit/libnetworking/net/if_ppp.c                                | 3 ++-
 cpukit/libnetworking/net/ppp_tty.c                               | 2 +-
 cpukit/libnetworking/net/route.c                                 | 2 +-
 cpukit/libnetworking/netinet/in.c                                | 2 +-
 cpukit/libnetworking/netinet/in_pcb.c                            | 2 +-
 cpukit/libnetworking/netinet/ip_mroute.c                         | 2 +-
 cpukit/libnetworking/rtems/rtems_bsdnet_internal.h               | 2 +-
 cpukit/libnetworking/rtems/rtems_dhcp.c                          | 2 +-
 cpukit/libnetworking/rtems/rtems_dhcp_failsafe.c                 | 2 +-
 cpukit/libnetworking/rtems/rtems_glue.c                          | 2 +-
 cpukit/libnetworking/rtems/rtems_showifstat.c                    | 2 +-
 testsuites/sptests/spfifo04/init.c                               | 1 +
 testsuites/sptests/spfifo05/init.c                               | 1 +
 27 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/c/src/lib/libbsp/arm/atsam/network/if_atsam.c b/c/src/lib/libbsp/arm/atsam/network/if_atsam.c
index 9a66912..7e7e0e6 100644
--- a/c/src/lib/libbsp/arm/atsam/network/if_atsam.c
+++ b/c/src/lib/libbsp/arm/atsam/network/if_atsam.c
@@ -46,7 +46,6 @@
 #include <rtems/rtems_mii_ioctl.h>
 
 #include <sys/types.h>
-#include <sys/ioctl.h>
 #include <sys/param.h>
 #include <sys/mbuf.h>
 #include <sys/socket.h>
diff --git a/c/src/lib/libbsp/powerpc/beatnik/network/if_gfe/if_gfe.c b/c/src/lib/libbsp/powerpc/beatnik/network/if_gfe/if_gfe.c
index 23fca30..04c09e8 100644
--- a/c/src/lib/libbsp/powerpc/beatnik/network/if_gfe/if_gfe.c
+++ b/c/src/lib/libbsp/powerpc/beatnik/network/if_gfe/if_gfe.c
@@ -76,9 +76,9 @@ __KERNEL_RCSID(0, "$NetBSD: if_gfe.c,v 1.13.8.1 2005/04/29 11:28:56 kent Exp $")
 #include <sys/device.h>
 #endif
 #include <sys/errno.h>
-#include <sys/ioctl.h>
 #include <sys/mbuf.h>
 #include <sys/socket.h>
+#include <sys/sockio.h>
 
 #ifndef __rtems__
 #include <machine/bus.h>
diff --git a/c/src/lib/libbsp/powerpc/mpc8260ads/network/if_hdlcsubr.c b/c/src/lib/libbsp/powerpc/mpc8260ads/network/if_hdlcsubr.c
index 96d0bf4..a083b39 100644
--- a/c/src/lib/libbsp/powerpc/mpc8260ads/network/if_hdlcsubr.c
+++ b/c/src/lib/libbsp/powerpc/mpc8260ads/network/if_hdlcsubr.c
@@ -57,7 +57,7 @@
 #include <sys/mbuf.h>
 #include <sys/protosw.h>
 #include <sys/socket.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <errno.h>
 #include <sys/syslog.h>
 #include <sys/sysctl.h>
diff --git a/c/src/lib/libbsp/powerpc/mvme5500/network/if_100MHz/GT64260eth.c b/c/src/lib/libbsp/powerpc/mvme5500/network/if_100MHz/GT64260eth.c
index fbabe98..85d5d0c 100644
--- a/c/src/lib/libbsp/powerpc/mvme5500/network/if_100MHz/GT64260eth.c
+++ b/c/src/lib/libbsp/powerpc/mvme5500/network/if_100MHz/GT64260eth.c
@@ -44,7 +44,6 @@
 
 /* #include <sys/queue.h> */
 
-#include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <sys/sockio.h>             /* SIOCADDMULTI, SIOC...     */
 #include <net/if.h>
diff --git a/c/src/lib/libbsp/powerpc/mvme5500/network/if_1GHz/if_wm.c b/c/src/lib/libbsp/powerpc/mvme5500/network/if_1GHz/if_wm.c
index 25be339..50cd633 100644
--- a/c/src/lib/libbsp/powerpc/mvme5500/network/if_1GHz/if_wm.c
+++ b/c/src/lib/libbsp/powerpc/mvme5500/network/if_1GHz/if_wm.c
@@ -61,7 +61,6 @@
 
 /* #include <sys/queue.h> */
 
-#include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <sys/sockio.h>             /* SIOCADDMULTI, SIOC...     */
 #include <net/if.h>
diff --git a/c/src/libchip/network/i82586.c b/c/src/libchip/network/i82586.c
index c06ed5f..8cb8140 100644
--- a/c/src/libchip/network/i82586.c
+++ b/c/src/libchip/network/i82586.c
@@ -161,7 +161,6 @@ Mode of operation:
 #include <sys/mbuf.h>
 #include <sys/socket.h>
 #include <sys/sockio.h>
-#include <sys/ioctl.h>
 
 #include <net/ethernet.h>
 #include <net/if.h>
diff --git a/cpukit/libcsupport/include/rtems/libio.h b/cpukit/libcsupport/include/rtems/libio.h
index d0824b4..4669cb5 100644
--- a/cpukit/libcsupport/include/rtems/libio.h
+++ b/cpukit/libcsupport/include/rtems/libio.h
@@ -27,7 +27,7 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <sys/ioctl.h>
+#include <sys/ioccom.h>
 #include <sys/statvfs.h>
 #include <sys/uio.h>
 
diff --git a/cpukit/libcsupport/src/termios.c b/cpukit/libcsupport/src/termios.c
index f310cb0..a22ae95 100644
--- a/cpukit/libcsupport/src/termios.c
+++ b/cpukit/libcsupport/src/termios.c
@@ -31,6 +31,7 @@
 #include <termios.h>
 #include <unistd.h>
 #include <sys/fcntl.h>
+#include <sys/filio.h>
 #include <sys/ttycom.h>
 
 #include <rtems/termiostypes.h>
diff --git a/cpukit/libfs/src/imfs/imfs_fifo.c b/cpukit/libfs/src/imfs/imfs_fifo.c
index d84429d..d6c2187 100644
--- a/cpukit/libfs/src/imfs/imfs_fifo.c
+++ b/cpukit/libfs/src/imfs/imfs_fifo.c
@@ -19,6 +19,8 @@
 
 #include "imfs.h"
 
+#include <sys/filio.h>
+
 #define JNODE2PIPE(_jnode)  ( ((IMFS_fifo_t *)(_jnode))->pipe )
 
 #define LIBIO2PIPE(_iop)  ( JNODE2PIPE((IMFS_jnode_t *)(_iop)->pathinfo.node_access) )
diff --git a/cpukit/libfs/src/pipe/fifo.c b/cpukit/libfs/src/pipe/fifo.c
index 104ecb5..49694d9 100644
--- a/cpukit/libfs/src/pipe/fifo.c
+++ b/cpukit/libfs/src/pipe/fifo.c
@@ -19,6 +19,7 @@
 #endif
 
 #include <sys/param.h>
+#include <sys/filio.h>
 #include <errno.h>
 #include <stdlib.h>
 #include <string.h>
diff --git a/cpukit/libmisc/shell/main_ifconfig.c b/cpukit/libmisc/shell/main_ifconfig.c
index 004018a..c19048f 100644
--- a/cpukit/libmisc/shell/main_ifconfig.c
+++ b/cpukit/libmisc/shell/main_ifconfig.c
@@ -17,6 +17,7 @@
 
 #include <netinet/in.h>
 #include <sys/types.h>
+#include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <arpa/inet.h>
 #include <net/if.h>
diff --git a/cpukit/libnetworking/net/if.c b/cpukit/libnetworking/net/if.c
index d0da62a..740bb90 100644
--- a/cpukit/libnetworking/net/if.c
+++ b/cpukit/libnetworking/net/if.c
@@ -44,7 +44,7 @@
 #include <sys/socketvar.h>
 #include <sys/protosw.h>
 #include <sys/kernel.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <errno.h>
 #include <sys/syslog.h>
 #include <sys/sysctl.h>
diff --git a/cpukit/libnetworking/net/if_ethersubr.c b/cpukit/libnetworking/net/if_ethersubr.c
index a98241a..0b87632 100644
--- a/cpukit/libnetworking/net/if_ethersubr.c
+++ b/cpukit/libnetworking/net/if_ethersubr.c
@@ -50,7 +50,7 @@
 #include <sys/mbuf.h>
 #include <sys/protosw.h>
 #include <sys/socket.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <errno.h>
 #include <sys/syslog.h>
 #include <sys/sysctl.h>
diff --git a/cpukit/libnetworking/net/if_loop.c b/cpukit/libnetworking/net/if_loop.c
index 9ddcc81..48cf014 100644
--- a/cpukit/libnetworking/net/if_loop.c
+++ b/cpukit/libnetworking/net/if_loop.c
@@ -52,7 +52,7 @@
 #include <sys/mbuf.h>
 #include <sys/socket.h>
 #include <errno.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <sys/time.h>
 
 #include <net/if.h>
diff --git a/cpukit/libnetworking/net/if_ppp.c b/cpukit/libnetworking/net/if_ppp.c
index 4549910..9284f6d 100644
--- a/cpukit/libnetworking/net/if_ppp.c
+++ b/cpukit/libnetworking/net/if_ppp.c
@@ -95,7 +95,8 @@
 #include <sys/proc.h>
 #include <sys/mbuf.h>
 #include <sys/socket.h>
-#include <sys/ioctl.h>
+#include <sys/filio.h>
+#include <sys/sockio.h>
 #include <sys/kernel.h>
 #include <sys/time.h>
 #include <sys/malloc.h>
diff --git a/cpukit/libnetworking/net/ppp_tty.c b/cpukit/libnetworking/net/ppp_tty.c
index e68124c..140a7e6 100644
--- a/cpukit/libnetworking/net/ppp_tty.c
+++ b/cpukit/libnetworking/net/ppp_tty.c
@@ -87,7 +87,7 @@
 #include <sys/proc.h>
 #include <sys/mbuf.h>
 #include <sys/socket.h>
-#include <sys/ioctl.h>
+#include <sys/filio.h>
 #include <sys/file.h>
 #include <sys/kernel.h>
 
diff --git a/cpukit/libnetworking/net/route.c b/cpukit/libnetworking/net/route.c
index b04649c..bb9f3ff 100644
--- a/cpukit/libnetworking/net/route.c
+++ b/cpukit/libnetworking/net/route.c
@@ -45,7 +45,7 @@
 #include <sys/socketvar.h>
 #include <sys/domain.h>
 #include <sys/protosw.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 
 #include <net/if.h>
 #include <net/route.h>
diff --git a/cpukit/libnetworking/netinet/in.c b/cpukit/libnetworking/netinet/in.c
index a23d4f5..372252c 100644
--- a/cpukit/libnetworking/netinet/in.c
+++ b/cpukit/libnetworking/netinet/in.c
@@ -37,7 +37,7 @@
 #include <sys/param.h>
 #include <sys/queue.h>
 #include <sys/systm.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <errno.h>
 #include <sys/malloc.h>
 #include <sys/socket.h>
diff --git a/cpukit/libnetworking/netinet/in_pcb.c b/cpukit/libnetworking/netinet/in_pcb.c
index 1cd9c92..bba5528 100644
--- a/cpukit/libnetworking/netinet/in_pcb.c
+++ b/cpukit/libnetworking/netinet/in_pcb.c
@@ -43,7 +43,7 @@
 #include <sys/protosw.h>
 #include <sys/socket.h>
 #include <sys/socketvar.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <errno.h>
 #include <sys/time.h>
 #include <sys/proc.h>
diff --git a/cpukit/libnetworking/netinet/ip_mroute.c b/cpukit/libnetworking/netinet/ip_mroute.c
index 92b4bb7..5fc3023 100644
--- a/cpukit/libnetworking/netinet/ip_mroute.c
+++ b/cpukit/libnetworking/netinet/ip_mroute.c
@@ -28,7 +28,7 @@
 #include <errno.h>
 #include <sys/time.h>
 #include <sys/kernel.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <sys/syslog.h>
 #include <net/if.h>
 #include <net/route.h>
diff --git a/cpukit/libnetworking/rtems/rtems_bsdnet_internal.h b/cpukit/libnetworking/rtems/rtems_bsdnet_internal.h
index fffe1b2..9608996 100644
--- a/cpukit/libnetworking/rtems/rtems_bsdnet_internal.h
+++ b/cpukit/libnetworking/rtems/rtems_bsdnet_internal.h
@@ -35,7 +35,7 @@ typedef	__uintptr_t		vm_size_t;
 #include <sys/cdefs.h>
 
 #include <sys/time.h>
-#include <sys/ioctl.h>
+#include <sys/ioccom.h>
 
 struct mdproc {
 	int	md_flags;
diff --git a/cpukit/libnetworking/rtems/rtems_dhcp.c b/cpukit/libnetworking/rtems/rtems_dhcp.c
index 74ea870..5f5515c 100644
--- a/cpukit/libnetworking/rtems/rtems_dhcp.c
+++ b/cpukit/libnetworking/rtems/rtems_dhcp.c
@@ -82,7 +82,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <sys/param.h>		/* for MAXHOSTNAMELEN */
 #include <sys/systm.h>
 #include <sys/socketvar.h>	/* for socreat() soclose() */
diff --git a/cpukit/libnetworking/rtems/rtems_dhcp_failsafe.c b/cpukit/libnetworking/rtems/rtems_dhcp_failsafe.c
index 46a411b..acdec13 100644
--- a/cpukit/libnetworking/rtems/rtems_dhcp_failsafe.c
+++ b/cpukit/libnetworking/rtems/rtems_dhcp_failsafe.c
@@ -63,7 +63,7 @@
 #include <rtems/rtems_dhcp_failsafe.h>
 
 struct  proc;                   /* Unused parameter of some functions. */
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <sys/socket.h>
 #include <net/route.h>
 #include <netinet/in.h>         /* for sockaddr_in */
diff --git a/cpukit/libnetworking/rtems/rtems_glue.c b/cpukit/libnetworking/rtems/rtems_glue.c
index ac75fb0..939b858 100644
--- a/cpukit/libnetworking/rtems/rtems_glue.c
+++ b/cpukit/libnetworking/rtems/rtems_glue.c
@@ -24,7 +24,7 @@
 #include <sys/sockio.h>
 #include <sys/callout.h>
 #include <sys/proc.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <sys/systm.h>
 #include <net/if.h>
 #include <net/route.h>
diff --git a/cpukit/libnetworking/rtems/rtems_showifstat.c b/cpukit/libnetworking/rtems/rtems_showifstat.c
index 2e06a8c..a936cf7 100644
--- a/cpukit/libnetworking/rtems/rtems_showifstat.c
+++ b/cpukit/libnetworking/rtems/rtems_showifstat.c
@@ -9,7 +9,7 @@
 #include <sys/sysctl.h>
 #include <sys/proc.h>
 #include <sys/socket.h>
-#include <sys/ioctl.h>
+#include <sys/sockio.h>
 #include <sys/mbuf.h>
 #include <net/if.h>
 #include <net/if_dl.h>
diff --git a/testsuites/sptests/spfifo04/init.c b/testsuites/sptests/spfifo04/init.c
index 5e2d1c1..157b45c 100644
--- a/testsuites/sptests/spfifo04/init.c
+++ b/testsuites/sptests/spfifo04/init.c
@@ -16,6 +16,7 @@
 #include <stdio.h>
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/ioctl.h>
 #include <fcntl.h>
 #include <unistd.h>
 #include <errno.h>
diff --git a/testsuites/sptests/spfifo05/init.c b/testsuites/sptests/spfifo05/init.c
index a5ce313..ab3ed66 100644
--- a/testsuites/sptests/spfifo05/init.c
+++ b/testsuites/sptests/spfifo05/init.c
@@ -16,6 +16,7 @@
 #include <stdio.h>
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/ioctl.h>
 #include <fcntl.h>
 #include <unistd.h>
 #include <errno.h>




More information about the vc mailing list