[rtems-libbsd commit] qbman: Fix platform_get_irq() error checks

Sebastian Huber sebh at rtems.org
Mon Oct 23 07:27:51 UTC 2017


Module:    rtems-libbsd
Branch:    master
Commit:    721b1c17631c36166714c94c63ad38525e0de0dc
Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=721b1c17631c36166714c94c63ad38525e0de0dc

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Wed May 17 09:25:39 2017 +0200

qbman: Fix platform_get_irq() error checks

---

 linux/drivers/soc/fsl/qbman/bman_ccsr.c   | 2 +-
 linux/drivers/soc/fsl/qbman/qman_ccsr.c   | 2 +-
 linux/drivers/soc/fsl/qbman/qman_portal.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/linux/drivers/soc/fsl/qbman/bman_ccsr.c b/linux/drivers/soc/fsl/qbman/bman_ccsr.c
index 1df1d9c..9fa5a6b 100644
--- a/linux/drivers/soc/fsl/qbman/bman_ccsr.c
+++ b/linux/drivers/soc/fsl/qbman/bman_ccsr.c
@@ -223,7 +223,7 @@ static int fsl_bman_probe(struct platform_device *pdev)
 	bm_set_memory(fbpr_a, fbpr_sz);
 
 	err_irq = platform_get_irq(pdev, 0);
-	if (err_irq <= 0) {
+	if (err_irq < 0) {
 		dev_info(dev, "Can't get %s IRQ\n", node->full_name);
 		return -ENODEV;
 	}
diff --git a/linux/drivers/soc/fsl/qbman/qman_ccsr.c b/linux/drivers/soc/fsl/qbman/qman_ccsr.c
index 7def343..51fc7bf 100644
--- a/linux/drivers/soc/fsl/qbman/qman_ccsr.c
+++ b/linux/drivers/soc/fsl/qbman/qman_ccsr.c
@@ -769,7 +769,7 @@ static int fsl_qman_probe(struct platform_device *pdev)
 	}
 
 	err_irq = platform_get_irq(pdev, 0);
-	if (err_irq <= 0) {
+	if (err_irq < 0) {
 		dev_info(dev, "Can't get %s property 'interrupts'\n",
 			 node->full_name);
 		return -ENODEV;
diff --git a/linux/drivers/soc/fsl/qbman/qman_portal.c b/linux/drivers/soc/fsl/qbman/qman_portal.c
index 640343a..ffef185 100644
--- a/linux/drivers/soc/fsl/qbman/qman_portal.c
+++ b/linux/drivers/soc/fsl/qbman/qman_portal.c
@@ -278,7 +278,7 @@ static int qman_portal_probe(struct platform_device *pdev)
 	pcfg->channel = val;
 	pcfg->cpu = -1;
 	irq = platform_get_irq(pdev, 0);
-	if (irq <= 0) {
+	if (irq < 0) {
 		dev_err(dev, "Can't get %s IRQ\n", node->full_name);
 		return -ENXIO;
 	}




More information about the vc mailing list