[rtems commit] psxinttypes01: Remove invalid test cases

Sebastian Huber sebh at rtems.org
Tue Nov 26 07:34:53 UTC 2019


Module:    rtems
Branch:    master
Commit:    e9fdcd79b73d3c4879ac64696d5de1fafb6cf8a2
Changeset: http://git.rtems.org/rtems/commit/?id=e9fdcd79b73d3c4879ac64696d5de1fafb6cf8a2

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Mon Nov 25 09:39:29 2019 +0100

psxinttypes01: Remove invalid test cases

The functions expect a valid string as input according to POSIX.  On
systems with a NULL pointer protection the test cases ended up in
exceptions.

---

 testsuites/psxtests/psxinttypes01/init.c            | 20 --------------------
 testsuites/psxtests/psxinttypes01/psxinttypes01.doc |  4 ----
 testsuites/psxtests/psxinttypes01/psxinttypes01.scn | 12 ++++++------
 3 files changed, 6 insertions(+), 30 deletions(-)

diff --git a/testsuites/psxtests/psxinttypes01/init.c b/testsuites/psxtests/psxinttypes01/init.c
index bfb6d4b..030aa2a 100644
--- a/testsuites/psxtests/psxinttypes01/init.c
+++ b/testsuites/psxtests/psxinttypes01/init.c
@@ -95,11 +95,6 @@ rtems_task Init(rtems_task_argument ignored)
   rtems_test_assert( result_strtoimax == INTMAX_MIN );
   rtems_test_assert( errno == ERANGE );
 
-  puts( "Invalid Input - Send NULL Pointer" );
-  result_strtoimax = strtoimax( NULL, &endptr1, base );
-  rtems_test_assert( result_strtoimax == 0 );
-  rtems_test_assert( errno == EINVAL );
-
   puts( "Invalid Input - Invalid base - Use base = 40" );
   result_strtoimax = strtoimax( nptr1_p, &endptr1, invalid_base );
   rtems_test_assert( result_strtoimax == 0 );
@@ -131,11 +126,6 @@ rtems_task Init(rtems_task_argument ignored)
   rtems_test_assert( result_strtoumax != 0 );
   rtems_test_assert( errno == ERANGE );
 
-  puts( "Invalid Input - Send NULL Pointer" );
-  result_strtoumax = strtoumax( NULL, &endptr1, base );
-  rtems_test_assert( result_strtoumax == 0 );
-  rtems_test_assert( errno == EINVAL );
-
   puts( "Invalid Input - Invalid base - Use base = 40" );
   result_strtoumax = strtoumax( nptr1_p, &endptr1, invalid_base );
   rtems_test_assert( result_strtoumax == 0 );
@@ -167,11 +157,6 @@ rtems_task Init(rtems_task_argument ignored)
   rtems_test_assert( result_strtoimax == INTMAX_MIN );
   rtems_test_assert( errno == ERANGE );
 
-  puts( "Invalid Input - Send NULL Pointer" );
-  result_strtoimax = wcstoimax( NULL, &endptr2, base );
-  rtems_test_assert( result_strtoimax == 0 );
-  rtems_test_assert( errno == EINVAL );
-
   puts( "Invalid Input - Invalid base - Use base = 40" );
   result_strtoimax = wcstoimax( nptr2_p, &endptr2, invalid_base );
   rtems_test_assert( result_strtoimax == 0 );
@@ -203,11 +188,6 @@ rtems_task Init(rtems_task_argument ignored)
   rtems_test_assert( result_strtoumax != 0 );
   rtems_test_assert( errno == ERANGE );
 
-  puts( "Invalid Input - Send NULL Pointer" );
-  result_strtoumax = wcstoumax( NULL, &endptr2, base );
-  rtems_test_assert( result_strtoumax == 0 );
-  rtems_test_assert( errno == EINVAL );
-
   puts( "Invalid Input - Invalid base - Use base = 40" );
   result_strtoumax = wcstoumax( nptr2_p, &endptr2, invalid_base );
   rtems_test_assert( result_strtoumax == 0 );
diff --git a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
index 607d670..19f63af 100644
--- a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
+++ b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc
@@ -12,7 +12,6 @@ test suite name: PSXINTTYPE 01
 	- checks for output for string having a positive number - Number Out of Range
 	- checks for output for string having a negative number - Number Out of Range
 	- checks for final string pointed by endptr
-	- checks for output for invalid argument - NULL Pointer
 	- checks for output for invalid argument - Invalid Base
 
 - Checks for Strtoumax Test Cases
@@ -21,7 +20,6 @@ test suite name: PSXINTTYPE 01
 	- checks for output for string having a positive number - Number Out of Range
 	- checks for output for string having a negative number - Number Out of Range
 	- checks for final string pointed by endptr
-	- checks for output for invalid argument - NULL Pointer
 	- checks for output for invalid argument - Invalid Base
 
 - Checks for Wcstoimax Testcases
@@ -30,7 +28,6 @@ test suite name: PSXINTTYPE 01
 	- checks for output for string having a positive number - Number Out of Range
 	- checks for output for string having a negative number - Number Out of Range
 	- checks for final string pointed by endptr
-	- checks for output for invalid argument - NULL Pointer
 	- checks for output for invalid argument - Invalid Base
 
 - Checks for Wcstoumax Testcases
@@ -39,5 +36,4 @@ test suite name: PSXINTTYPE 01
 	- checks for output for string having a positive number - Number Out of Range
 	- checks for output for string having a negative number - Number Out of Range
 	- checks for final string pointed by endptr
-	- checks for output for invalid argument - NULL Pointer
 	- checks for output for invalid argument - Invalid Base
diff --git a/testsuites/psxtests/psxinttypes01/psxinttypes01.scn b/testsuites/psxtests/psxinttypes01/psxinttypes01.scn
index 09aec29..46dc6b0 100644
--- a/testsuites/psxtests/psxinttypes01/psxinttypes01.scn
+++ b/testsuites/psxtests/psxinttypes01/psxinttypes01.scn
@@ -1,4 +1,8 @@
-*** PSXINTTYPE 01 TEST ***
+*** BEGIN OF TEST PSXINTTYPE 01 ***
+*** TEST VERSION: 5.0.0.5c2e7104e7de6ac70fae6e8d1e84c9f36c476d43
+*** TEST STATE: EXPECTED-PASS
+*** TEST BUILD:
+*** TEST TOOLS: 7.4.1 20190514 (RTEMS 5, RSB a50f0c044ad732db728cc942d5fde82a1faf1d12, Newlib d14714c69)
 
 strtoimax Testcases....
 Valid Inputs - Positive Number
@@ -7,7 +11,6 @@ Valid Inputs - Negative Number
 Final string pointed by endptr
 Valid Input - Positive Number - Number out of Range
 Valid Input - Negative Number - Number out of Range
-Invalid Input - Send NULL Pointer
 Invalid Input - Invalid base - Use base = 40
 
 strtoumax Testcases....
@@ -17,7 +20,6 @@ Valid Inputs - Negative Number
 Final string pointed by endptr
 Valid Input - Positive Number - Number out of Range
 Valid Input - Negative Number - Number out of Range
-Invalid Input - Send NULL Pointer
 Invalid Input - Invalid base - Use base = 40
 
 wcstoimax Testcases....
@@ -27,7 +29,6 @@ Valid Inputs - Negative Number
 Final string pointed by endptr
 Valid Input - Positive Number - Number out of Range
 Valid Input - Negative Number - Number out of Range
-Invalid Input - Send NULL Pointer
 Invalid Input - Invalid base - Use base = 40
 
 wcstoumax Testcases....
@@ -37,7 +38,6 @@ Valid Inputs - Negative Number
 Final string pointed by endptr
 Valid Input - Positive Number - Number out of Range
 Valid Input - Negative Number - Number out of Range
-Invalid Input - Send NULL Pointer
 Invalid Input - Invalid base - Use base = 40
 
-*** END OF PSXINTTYPE 01 TEST ***
+*** END OF TEST PSXINTTYPE 01 ***



More information about the vc mailing list