[rtems-libbsd commit] Fix warnings

Sebastian Huber sebh at rtems.org
Wed Sep 25 07:30:32 UTC 2019


Module:    rtems-libbsd
Branch:    master
Commit:    4a77611a223ea883fb548679b516d326a020d447
Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=4a77611a223ea883fb548679b516d326a020d447

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Tue Sep 24 14:20:34 2019 +0200

Fix warnings

---

 testsuite/cdev01/test_main.c               | 5 +++--
 testsuite/log01/test_main.c                | 3 +++
 testsuite/media01/test_main.c              | 1 +
 testsuite/termios/test_termios_utilities.h | 5 ++++-
 testsuite/termios06/test_main.c            | 3 +--
 testsuite/usbkbd01/init.c                  | 7 +++----
 testsuite/usbmouse01/init.c                | 7 +++----
 7 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/testsuite/cdev01/test_main.c b/testsuite/cdev01/test_main.c
index 23aefa8..a72985e 100644
--- a/testsuite/cdev01/test_main.c
+++ b/testsuite/cdev01/test_main.c
@@ -73,6 +73,7 @@ static void test_cdev(const char *path)
 	struct pollfd fds[1];
 	int kq;
 	struct kevent change;
+	void *p;
 
 	test_make_dev(&state, name);
 
@@ -126,8 +127,8 @@ static void test_cdev(const char *path)
 	assert(rv == -1);
 	assert(errno == TEST_KQ_ERRNO);
 
-	rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
-	assert(rv == 0);
+	p = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
+	assert(p == NULL);
 
 	rv = close(fd);
 	assert(rv == 0);
diff --git a/testsuite/log01/test_main.c b/testsuite/log01/test_main.c
index 63077a5..45f62cd 100644
--- a/testsuite/log01/test_main.c
+++ b/testsuite/log01/test_main.c
@@ -44,6 +44,9 @@
 
 #include <rtems/bsd/bsd.h>
 
+/* Only visible in <sys/syslog.h> if _KERNEL is undefined */
+void	syslog(int, const char *, ...) __printflike(2, 3);
+
 #define TEST_NAME "LIBBSD LOG 1"
 
 typedef struct {
diff --git a/testsuite/media01/test_main.c b/testsuite/media01/test_main.c
index 1611ba3..732f34e 100644
--- a/testsuite/media01/test_main.c
+++ b/testsuite/media01/test_main.c
@@ -41,6 +41,7 @@
 #include <rtems/ftpd.h>
 #include <rtems/media.h>
 #include <rtems/record.h>
+#include <rtems/recordserver.h>
 #include <rtems/shell.h>
 #include <rtems/telnetd.h>
 
diff --git a/testsuite/termios/test_termios_utilities.h b/testsuite/termios/test_termios_utilities.h
index c655c6f..52770fe 100644
--- a/testsuite/termios/test_termios_utilities.h
+++ b/testsuite/termios/test_termios_utilities.h
@@ -10,10 +10,13 @@
 #ifndef TEST_TERMIOS_UTILITIES_H
 #define TEST_TERMIOS_UTILITIES_H
 
+#include <sys/types.h>
+
 #define TX_MAX 1024
 
 extern void open_it(void);
 extern void close_it(void);
+extern void read_it(ssize_t expected);
 extern void change_iflag(const char *desc, int mask, int new);
 extern void change_lflag(const char *desc, int mask, int new);
 extern void change_oflag(const char *desc, int mask, int new);
@@ -30,4 +33,4 @@ extern int Test_fd;
 extern uint8_t read_helper_buffer[256];
 extern uint8_t Tx_Buffer[TX_MAX];
 
-#endif /* TEST_TERMIOS_UTILITIES_H */
\ No newline at end of file
+#endif /* TEST_TERMIOS_UTILITIES_H */
diff --git a/testsuite/termios06/test_main.c b/testsuite/termios06/test_main.c
index 9290ef2..d70b7bd 100644
--- a/testsuite/termios06/test_main.c
+++ b/testsuite/termios06/test_main.c
@@ -29,7 +29,6 @@
 #define TEST_NAME "LIBBSD TERMIOS 6"
 
 static struct termios term;
-static rtems_id flush_task_id;
 
 static void init_term(void)
 {
@@ -489,4 +488,4 @@ test_main(void)
   exit(0);
 }
 
-#include <rtems/bsd/test/default-termios-init.h>
\ No newline at end of file
+#include <rtems/bsd/test/default-termios-init.h>
diff --git a/testsuite/usbkbd01/init.c b/testsuite/usbkbd01/init.c
index bec5a22..2322a49 100644
--- a/testsuite/usbkbd01/init.c
+++ b/testsuite/usbkbd01/init.c
@@ -99,9 +99,8 @@ usb_keyboard_open_task(rtems_task_argument arg)
 {
 	rtems_status_code sc;
 	struct usb_test_message msg;
-	struct termios t;
 	uint32_t size;
-	int fd, iret;
+	int fd;
 
 	fd = -2;
 	otask_active = true;
@@ -182,10 +181,10 @@ Init(rtems_task_argument arg)
 	);
 	assert(sc == RTEMS_SUCCESSFUL);
 
-	sc = rtems_task_start(rid, usb_keyboard_read_task, NULL);
+	sc = rtems_task_start(rid, usb_keyboard_read_task, 0);
 	assert(sc == RTEMS_SUCCESSFUL);
 
-	sc = rtems_task_start(oid, usb_keyboard_open_task, NULL);
+	sc = rtems_task_start(oid, usb_keyboard_open_task, 0);
 	assert(sc == RTEMS_SUCCESSFUL);
 
 	sc = rtems_bsd_initialize();
diff --git a/testsuite/usbmouse01/init.c b/testsuite/usbmouse01/init.c
index b607c2a..78edf66 100644
--- a/testsuite/usbmouse01/init.c
+++ b/testsuite/usbmouse01/init.c
@@ -104,9 +104,8 @@ usb_mouse_open_task(rtems_task_argument arg)
 {
 	rtems_status_code sc;
 	struct usb_test_message msg;
-	struct termios t;
 	uint32_t size;
-	int fd, iret;
+	int fd;
 
 	fd = -2;
 	otask_active = true;
@@ -187,10 +186,10 @@ Init(rtems_task_argument arg)
 	);
 	assert(sc == RTEMS_SUCCESSFUL);
 
-	sc = rtems_task_start(rid, usb_mouse_read_task, NULL);
+	sc = rtems_task_start(rid, usb_mouse_read_task, 0);
 	assert(sc == RTEMS_SUCCESSFUL);
 
-	sc = rtems_task_start(oid, usb_mouse_open_task, NULL);
+	sc = rtems_task_start(oid, usb_mouse_open_task, 0);
 	assert(sc == RTEMS_SUCCESSFUL);
 
 	sc = rtems_bsd_initialize();




More information about the vc mailing list