[rtems commit] libfdt: Correct prototype for fdt_ro_probe_()

Sebastian Huber sebh at rtems.org
Mon Mar 2 06:52:34 UTC 2020


Module:    rtems
Branch:    master
Commit:    7217a4f40b2fa8885b2b5acff316bd10afe59ec5
Changeset: http://git.rtems.org/rtems/commit/?id=7217a4f40b2fa8885b2b5acff316bd10afe59ec5

Author:    David Gibson <david at gibson.dropbear.id.au>
Date:      Fri Nov  8 14:42:53 2019 +0000

libfdt: Correct prototype for fdt_ro_probe_()

This function returns an int32_t, however the prototype in
libfdt_internal.h shows it returning an int.  We haven't caught this before
because they're the same type on nearly all platforms this gets built on.
Apparently it's not the case on FreeRTOS, so someone hit this mismatch
building for that platform.

Reported-by: dharani kumar <dharanikumarsrvn at gmail.com>
Signed-off-by: David Gibson <david at gibson.dropbear.id.au>

---

 cpukit/dtc/libfdt/libfdt_internal.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpukit/dtc/libfdt/libfdt_internal.h b/cpukit/dtc/libfdt/libfdt_internal.h
index 741eeb3..058c735 100644
--- a/cpukit/dtc/libfdt/libfdt_internal.h
+++ b/cpukit/dtc/libfdt/libfdt_internal.h
@@ -10,10 +10,10 @@
 #define FDT_ALIGN(x, a)		(((x) + (a) - 1) & ~((a) - 1))
 #define FDT_TAGALIGN(x)		(FDT_ALIGN((x), FDT_TAGSIZE))
 
-int fdt_ro_probe_(const void *fdt);
+int32_t fdt_ro_probe_(const void *fdt);
 #define FDT_RO_PROBE(fdt)					\
 	{							\
-		int totalsize_;					\
+		int32_t totalsize_;				\
 		if ((totalsize_ = fdt_ro_probe_(fdt)) < 0)	\
 			return totalsize_;			\
 	}



More information about the vc mailing list