[rtems commit] main_rtrace.c: Add error return when malloc fails

Joel Sherrill joel at rtems.org
Thu Apr 29 15:27:04 UTC 2021


Module:    rtems
Branch:    master
Commit:    8cf30c41d9336f61e37eeb29617e5a13532c7c3d
Changeset: http://git.rtems.org/rtems/commit/?id=8cf30c41d9336f61e37eeb29617e5a13532c7c3d

Author:    Ryan Long <ryan.long at oarcorp.com>
Date:      Wed Mar 10 13:51:20 2021 -0500

main_rtrace.c: Add error return when malloc fails

CID 1399709: Dereference after null check in
rtems_trace_buffering_shell_save().

Closes #4329

---

 cpukit/libmisc/shell/main_rtrace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cpukit/libmisc/shell/main_rtrace.c b/cpukit/libmisc/shell/main_rtrace.c
index 753ab9d..e4f59c4 100644
--- a/cpukit/libmisc/shell/main_rtrace.c
+++ b/cpukit/libmisc/shell/main_rtrace.c
@@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char *argv[])
   {
     close (out);
     printf ("error: no memory\n");
+    return 1;
   }
 
   memset (buf, 0, SAVE_BUF_SIZE);



More information about the vc mailing list