[rtems commit] libfdt: Add FDT alignment check to fdt_check_header()
Sebastian Huber
sebh at rtems.org
Thu Dec 16 13:58:33 UTC 2021
Module: rtems
Branch: master
Commit: 34052ef78cf8724dee73e9279b2c6bff8cfed234
Changeset: http://git.rtems.org/rtems/commit/?id=34052ef78cf8724dee73e9279b2c6bff8cfed234
Author: Rob Herring <robh at kernel.org>
Date: Tue Apr 6 14:07:12 2021 -0500
libfdt: Add FDT alignment check to fdt_check_header()
Only checking the FDT alignment in fdt_ro_probe_() means that
fdt_check_header() can pass, but then subsequent API calls fail on
alignment checks. Let's add an alignment check to fdt_check_header() so
alignment errors are found up front.
Cc: Tom Rini <trini at konsulko.com>
Cc: Frank Rowand <frowand.list at gmail.com>
Signed-off-by: Rob Herring <robh at kernel.org>
Message-Id: <20210406190712.2118098-1-robh at kernel.org>
Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
---
cpukit/dtc/libfdt/fdt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/cpukit/dtc/libfdt/fdt.c b/cpukit/dtc/libfdt/fdt.c
index 3e89307..9fe7cf4 100644
--- a/cpukit/dtc/libfdt/fdt.c
+++ b/cpukit/dtc/libfdt/fdt.c
@@ -90,6 +90,10 @@ int fdt_check_header(const void *fdt)
{
size_t hdrsize;
+ /* The device tree must be at an 8-byte aligned address */
+ if ((uintptr_t)fdt & 7)
+ return -FDT_ERR_ALIGNMENT;
+
if (fdt_magic(fdt) != FDT_MAGIC)
return -FDT_ERR_BADMAGIC;
if (!can_assume(LATEST)) {
More information about the vc
mailing list