[rtems-central commit] interface: Do not add group dependencies

Sebastian Huber sebh at rtems.org
Wed Jul 21 17:20:21 UTC 2021


Module:    rtems-central
Branch:    master
Commit:    7aa538b88d8ddafd185db8f7e4fc8482012053ca
Changeset: http://git.rtems.org/rtems-central/commit/?id=7aa538b88d8ddafd185db8f7e4fc8482012053ca

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Fri Jul 16 09:06:06 2021 +0200

interface: Do not add group dependencies

Do not use the interface groups for interface dependencies.  Since this
could lead to cyclic dependencies.  For example, a group could be placed
in a header file and the header file could belong to the group.

---

 rtemsspec/interface.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/rtemsspec/interface.py b/rtemsspec/interface.py
index 4a637cf..b275d37 100644
--- a/rtemsspec/interface.py
+++ b/rtemsspec/interface.py
@@ -320,8 +320,6 @@ class Node:
 
     def generate_group(self) -> None:
         """ Generates a group. """
-        for ingroup in self.ingroups.values():
-            self.header_file.add_dependency(self, ingroup)
         self.content.add_group(self.item["identifier"], self.item["name"],
                                _get_group_identifiers(self.ingroups),
                                self.substitute_text(self.item["brief"]),
@@ -698,16 +696,11 @@ class _HeaderFile:
             node.depends_on.add(other)
             other.dependents.add(node)
 
-    def _resolve_ingroups(self, node: Node) -> None:
-        for ingroup in node.ingroups.values():
-            self.add_dependency(node, ingroup)
-
     def generate_nodes(self) -> None:
         """ Generates all nodes of this header file. """
         for child in self._item.children("interface-placement"):
             self._add_child(child)
         for node in self._nodes.values():
-            self._resolve_ingroups(node)
             node.generate()
 
     def _get_nodes_in_dependency_order(self) -> List[Node]:



More information about the vc mailing list