[rtems-tools commit] TraceReaderLogQEMU.cc: Fix resource leak

Joel Sherrill joel at rtems.org
Fri Jun 4 17:23:14 UTC 2021


Module:    rtems-tools
Branch:    master
Commit:    dfe012de71ec8550f158fc51e9c48fb06e37d32e
Changeset: http://git.rtems.org/rtems-tools/commit/?id=dfe012de71ec8550f158fc51e9c48fb06e37d32e

Author:    Ryan Long <ryan.long at oarcorp.com>
Date:      Mon May 17 13:23:30 2021 -0400

TraceReaderLogQEMU.cc: Fix resource leak

CID 1399615: Resource leak in processFile().

Closes #4419

---

 tester/covoar/TraceReaderLogQEMU.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tester/covoar/TraceReaderLogQEMU.cc b/tester/covoar/TraceReaderLogQEMU.cc
index 508074a..b64a149 100644
--- a/tester/covoar/TraceReaderLogQEMU.cc
+++ b/tester/covoar/TraceReaderLogQEMU.cc
@@ -109,12 +109,12 @@ namespace Trace {
       return false;
     }
 
-
     //
     //  Discard Header section
     //
     if (! ReadUntilFound( logFile, QEMU_LOG_SECTION_END ) ) {
       fprintf( stderr, "Unable to locate end of log file header\n" );
+      fclose( logFile );
       return false;
     }
 
@@ -123,6 +123,7 @@ namespace Trace {
     //
     if (! ReadUntilFound( logFile, QEMU_LOG_IN_KEY )){
       fprintf(stderr,"Error: Unable to locate first IN: Block in Log file \n");
+      fclose( logFile );
       return false;
     }
 



More information about the vc mailing list