[rtems commit] cpuusagetop.c: Fix three Missing break in switch Coverity errors

Joel Sherrill joel at rtems.org
Fri Mar 5 20:19:38 UTC 2021


Module:    rtems
Branch:    master
Commit:    c7eb89f82b4c0572917cc7bc31dfecb08a6685ee
Changeset: http://git.rtems.org/rtems/commit/?id=c7eb89f82b4c0572917cc7bc31dfecb08a6685ee

Author:    Ryan Long <ryan.long at oarcorp.com>
Date:      Mon Mar  1 16:06:41 2021 -0500

cpuusagetop.c: Fix three Missing break in switch Coverity errors

CID 1399726: Missing break in switch in task_usage().
CID 1399728: Missing break in switch in task_usage().
CID 1399742: Missing break in switch in task_usage().

Closes #4278

---

 cpukit/libmisc/cpuuse/cpuusagetop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/cpukit/libmisc/cpuuse/cpuusagetop.c b/cpukit/libmisc/cpuuse/cpuusagetop.c
index 9f19b27..dad11ad 100644
--- a/cpukit/libmisc/cpuuse/cpuusagetop.c
+++ b/cpukit/libmisc/cpuuse/cpuusagetop.c
@@ -228,9 +228,11 @@ task_usage(Thread_Control* thread, void* arg)
           if (CPU_usage_Equal_to(&usage, &data->zero) ||
               CPU_usage_Less_than(&usage, &data->usage[j]))
             continue;
+          /* Fall through */
         case RTEMS_TOP_SORT_REAL_PRI:
           if (thread->Real_priority.priority > data->tasks[j]->Real_priority.priority)
             continue;
+          /* Fall through */
         case RTEMS_TOP_SORT_CURRENT_PRI:
           if (
             _Thread_Get_priority( thread )
@@ -238,6 +240,7 @@ task_usage(Thread_Control* thread, void* arg)
           ) {
             continue;
           }
+          /* Fall through */
         case RTEMS_TOP_SORT_ID:
           if (thread->Object.id < data->tasks[j]->Object.id)
             continue;



More information about the vc mailing list