[rtems-central commit] spec: Improve or fix wording

Sebastian Huber sebh at rtems.org
Thu Mar 11 21:05:50 UTC 2021


Module:    rtems-central
Branch:    master
Commit:    ee426f9ed481a0b5be338e824aba0b6d758ff494
Changeset: http://git.rtems.org/rtems-central/commit/?id=ee426f9ed481a0b5be338e824aba0b6d758ff494

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Thu Mar 11 11:21:14 2021 +0100

spec: Improve or fix wording

---

 spec/rtems/barrier/req/create.yml           |  2 +-
 spec/rtems/barrier/req/delete.yml           |  4 ++--
 spec/rtems/event/req/send-receive.yml       |  2 +-
 spec/rtems/message/req/construct-errors.yml |  2 +-
 spec/rtems/part/req/create.yml              |  2 +-
 spec/rtems/part/req/delete.yml              |  5 +++--
 spec/rtems/part/req/get-buffer.yml          |  2 +-
 spec/rtems/signal/req/catch.yml             | 10 ++++++----
 spec/rtems/task/req/construct-errors.yml    |  2 +-
 spec/rtems/task/req/create-errors.yml       |  2 +-
 10 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/spec/rtems/barrier/req/create.yml b/spec/rtems/barrier/req/create.yml
index c70bf44..b648e54 100644
--- a/spec/rtems/barrier/req/create.yml
+++ b/spec/rtems/barrier/req/create.yml
@@ -186,7 +186,7 @@ pre-conditions:
     test-code: |
       ctx->seized_objects = T_seize_objects( Create, NULL );
     text: |
-      The system shall have no inactive partition object available.
+      The system shall not have an inactive barrier object available.
   test-epilogue: null
   test-prologue: null
 rationale: null
diff --git a/spec/rtems/barrier/req/delete.yml b/spec/rtems/barrier/req/delete.yml
index f4e37cc..9ea4728 100644
--- a/spec/rtems/barrier/req/delete.yml
+++ b/spec/rtems/barrier/req/delete.yml
@@ -33,13 +33,13 @@ post-conditions:
       T_rsc_success( sc );
       T_eq_u32( id, ctx->barrier_id );
     text: |
-      The unique object name shall identify the barrier.
+      The unique object name shall identify a barrier.
   - name: Invalid
     test-code: |
       sc = rtems_barrier_ident( NAME, &id );
       T_rsc( sc, RTEMS_INVALID_NAME );
     text: |
-      The unique object name shall not identify the barrier.
+      The unique object name shall not identify a barrier.
   test-epilogue: null
   test-prologue: |
     rtems_status_code sc;
diff --git a/spec/rtems/event/req/send-receive.yml b/spec/rtems/event/req/send-receive.yml
index f303ef8..3512396 100644
--- a/spec/rtems/event/req/send-receive.yml
+++ b/spec/rtems/event/req/send-receive.yml
@@ -26,7 +26,7 @@ post-conditions:
       T_eq_int( ctx->receive_condition_state, RECEIVE_COND_UNKNOWN );
       T_eq_u32( GetPendingEvents( ctx ), 0 );
     text: |
-      The receiver task shall have no pending events.
+      The receiver task shall not have pending events.
   - name: Pending
     test-code: |
       T_eq_int( ctx->receive_condition_state, RECEIVE_COND_UNKNOWN );
diff --git a/spec/rtems/message/req/construct-errors.yml b/spec/rtems/message/req/construct-errors.yml
index 8ec11a4..b1a59f2 100644
--- a/spec/rtems/message/req/construct-errors.yml
+++ b/spec/rtems/message/req/construct-errors.yml
@@ -195,7 +195,7 @@ pre-conditions:
       i = 0;
       ctx->seized_objects = T_seize_objects( Create, &i );
     text: |
-      The system shall have no inactive message queue object available.
+      The system shall not have an inactive message queue object available.
   test-epilogue: null
   test-prologue: |
     size_t i;
diff --git a/spec/rtems/part/req/create.yml b/spec/rtems/part/req/create.yml
index 593be23..3030b75 100644
--- a/spec/rtems/part/req/create.yml
+++ b/spec/rtems/part/req/create.yml
@@ -214,7 +214,7 @@ pre-conditions:
       i = 0;
       ctx->seized_objects = T_seize_objects( Create, &i );
     text: |
-      The system shall have no inactive partition object available.
+      The system shall not have an inactive partition object available.
   test-epilogue: null
   test-prologue: |
     size_t i;
diff --git a/spec/rtems/part/req/delete.yml b/spec/rtems/part/req/delete.yml
index 4a24767..85bf9f9 100644
--- a/spec/rtems/part/req/delete.yml
+++ b/spec/rtems/part/req/delete.yml
@@ -52,7 +52,8 @@ pre-conditions:
     test-code: |
       ctx->id = 0xffffffff;
     text: |
-      The ${../if/delete:/params[0]/name} parameter shall be invalid.
+      The ${../if/delete:/params[0]/name} parameter shall not be associated
+      with a partition.
   - name: Part
     test-code: |
       ctx->id = ctx->id_value;
@@ -75,7 +76,7 @@ pre-conditions:
     test-code: |
       ctx->buffer = NULL;
     text: |
-      The partition shall have no buffer in use.
+      The partition shall not have a buffer in use.
   test-epilogue: null
   test-prologue: |
     rtems_status_code sc;
diff --git a/spec/rtems/part/req/get-buffer.yml b/spec/rtems/part/req/get-buffer.yml
index 8c9a73b..2157e4e 100644
--- a/spec/rtems/part/req/get-buffer.yml
+++ b/spec/rtems/part/req/get-buffer.yml
@@ -101,7 +101,7 @@ pre-conditions:
       sc = rtems_partition_get_buffer( ctx->id_value, &ctx->stolen_buffer );
       T_rsc_success( sc );
     text: |
-      The partition shall have no buffer available.
+      The partition shall not have a buffer available.
   test-epilogue: null
   test-prologue: |
     rtems_status_code sc;
diff --git a/spec/rtems/signal/req/catch.yml b/spec/rtems/signal/req/catch.yml
index ebf5ea8..c60d68e 100644
--- a/spec/rtems/signal/req/catch.yml
+++ b/spec/rtems/signal/req/catch.yml
@@ -170,14 +170,16 @@ pre-conditions:
     test-code: |
       ctx->pending_signals = ( rtems_scheduler_get_processor_maximum() > 1 ) ? 1 : 0;
     text: |
-      Where the system has more than one processor, when ${../if/catch:/name}
-      is called, the calling task shall have pending signals.
+      Where the system has more than one processor, while the calling task has
+      pending signals, the ${../if/catch:/name} directive shall be called.
+      Where the system has exactly one processor, while the calling task has no
+      pending signals, the ${../if/catch:/name} directive shall be called.
   - name: 'No'
     test-code: |
       ctx->pending_signals = 0;
     text: |
-      When ${../if/catch:/name} is called, the calling task shall have no
-      pending signals.
+      While the calling task has no pending signals, the ${../if/catch:/name}
+      directive shall be called.
   test-epilogue: null
   test-prologue: null
 - name: Handler
diff --git a/spec/rtems/task/req/construct-errors.yml b/spec/rtems/task/req/construct-errors.yml
index ab1fbc5..96d6a5c 100644
--- a/spec/rtems/task/req/construct-errors.yml
+++ b/spec/rtems/task/req/construct-errors.yml
@@ -219,7 +219,7 @@ pre-conditions:
     test-code: |
       ctx->seized_objects = T_seize_objects( Create, ctx );
     text: |
-      The system shall have no inactive task object available.
+      The system shall not have an inactive task object available.
   test-epilogue: null
   test-prologue: null
 - name: TLS
diff --git a/spec/rtems/task/req/create-errors.yml b/spec/rtems/task/req/create-errors.yml
index 3703b86..0861bfe 100644
--- a/spec/rtems/task/req/create-errors.yml
+++ b/spec/rtems/task/req/create-errors.yml
@@ -197,7 +197,7 @@ pre-conditions:
     test-code: |
       ctx->seized_objects = T_seize_objects( Create, ctx );
     text: |
-      The system shall have no inactive task object available.
+      The system shall not have an inactive task object available.
   test-epilogue: null
   test-prologue: null
 - name: Stack



More information about the vc mailing list