[rtems commit] libdtc: remove duplicate judgments
Sebastian Huber
sebh at rtems.org
Thu Dec 22 06:49:24 UTC 2022
Module: rtems
Branch: master
Commit: b4d005e3fb44e1ffb006fb0ac2d0e890fdc2bd35
Changeset: http://git.rtems.org/rtems/commit/?id=b4d005e3fb44e1ffb006fb0ac2d0e890fdc2bd35
Author: Jia Xianhua <jiaxianhua at gmail.com>
Date: Thu Sep 15 16:47:03 2022 +0800
libdtc: remove duplicate judgments
There is no need to check the VALID_DTB repeatedly, and can be combined
into one if statement.
Signed-off-by: Jia Xianhua <jiaxianhua at gmail.com>
Signed-off-by: David Gibson <david at gibson.dropbear.id.au>
---
cpukit/dtc/libfdt/fdt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/cpukit/dtc/libfdt/fdt.c b/cpukit/dtc/libfdt/fdt.c
index 9fe7cf4b74..90a39e8fb7 100644
--- a/cpukit/dtc/libfdt/fdt.c
+++ b/cpukit/dtc/libfdt/fdt.c
@@ -106,7 +106,6 @@ int fdt_check_header(const void *fdt)
}
hdrsize = fdt_header_size(fdt);
if (!can_assume(VALID_DTB)) {
-
if ((fdt_totalsize(fdt) < hdrsize)
|| (fdt_totalsize(fdt) > INT_MAX))
return -FDT_ERR_TRUNCATED;
@@ -115,9 +114,7 @@ int fdt_check_header(const void *fdt)
if (!check_off_(hdrsize, fdt_totalsize(fdt),
fdt_off_mem_rsvmap(fdt)))
return -FDT_ERR_TRUNCATED;
- }
- if (!can_assume(VALID_DTB)) {
/* Bounds check structure block */
if (!can_assume(LATEST) && fdt_version(fdt) < 17) {
if (!check_off_(hdrsize, fdt_totalsize(fdt),
More information about the vc
mailing list