[rtems-tools commit] tester/exe: Fix adjust timeouts by the step size

Sebastian Huber sebh at rtems.org
Mon Jan 10 12:48:13 UTC 2022


Module:    rtems-tools
Branch:    master
Commit:    f73627e3642f1f8295d3fc2c11fa852d9718e734
Changeset: http://git.rtems.org/rtems-tools/commit/?id=f73627e3642f1f8295d3fc2c11fa852d9718e734

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Wed Dec 22 09:18:20 2021 +0100

tester/exe: Fix adjust timeouts by the step size

The bug was introduced by cfd5aa41e847752cd98cde65515df7ce45ff9665.

The code monitors the test and generates a timeout test failure.  There are two
layers of timeout, one for output and the other for a test running too long.

The test needs to generate some output within the first timeout period and the
second timeout detects if the test has run too long. The first timeout detects
a target has locked up. The second is for a test looping generating output.

With exe type tests the output is buffered in a separate thread.

---

 tester/rt/exe.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tester/rt/exe.py b/tester/rt/exe.py
index 626899e..8a36aca 100644
--- a/tester/rt/exe.py
+++ b/tester/rt/exe.py
@@ -116,12 +116,12 @@ class exe(object):
     def _monitor(self, timeout):
         output_length = self.output_length
         step = 0.25
-        period = timeout[0] * step
-        seconds = timeout[1] * step
+        period = timeout[0] / step
+        seconds = timeout[1] / step
         while self.process and period > 0 and seconds > 0:
             current_length = self.output_length
             if output_length != current_length:
-                period = timeout[0] * step
+                period = timeout[0] / step
             output_length = current_length
             if seconds < step:
                 seconds = 0



More information about the vc mailing list