[rtems commit] bsps/riscv: Simplify riscv_clint_init()

[Sebastian Huber]

Module:    rtems
Branch:    master
Commit:    d2bac3d73093d15185c126acc41fef3e4c4f895a
Changeset: http://git.rtems.org/rtems/commit/?id=d2bac3d73093d15185c126acc41fef3e4c4f895a

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Thu Nov 10 08:21:47 2022 +0100

bsps/riscv: Simplify riscv_clint_init()

---

 bsps/riscv/riscv/irq/irq.c | 39 +++++++++++++++++++++++++--------------
 1 file changed, 25 insertions(+), 14 deletions(-)

diff --git a/bsps/riscv/riscv/irq/irq.c b/bsps/riscv/riscv/irq/irq.c
index 3f750e5c4c..7f5cc01e7b 100644
--- a/bsps/riscv/riscv/irq/irq.c
+++ b/bsps/riscv/riscv/irq/irq.c
@@ -115,6 +115,16 @@ void _RISCV_Interrupt_dispatch(uintptr_t mcause, Per_CPU_Control *cpu_self)
   }
 }
 
+static void riscv_clint_per_cpu_init(
+  volatile RISCV_CLINT_regs *clint,
+  Per_CPU_Control *cpu,
+  uint32_t index
+)
+{
+  cpu->cpu_per_cpu.clint_msip = &clint->msip[index];
+  cpu->cpu_per_cpu.clint_mtimecmp = &clint->mtimecmp[index];
+}
+
 static void riscv_clint_init(const void *fdt)
 {
   volatile RISCV_CLINT_regs *clint;
@@ -136,30 +146,31 @@ static void riscv_clint_init(const void *fdt)
 
   for (i = 0; i < len; i += 16) {
     uint32_t hart_index;
-    Per_CPU_Control *cpu;
+    uint32_t cpu_index;
 
     hart_index = riscv_get_hart_index_by_phandle(fdt32_to_cpu(val[i / 4]));
-#ifdef RTEMS_SMP
-    if (hart_index < RISCV_BOOT_HARTID) {
-      continue;
-    }
 
-    hart_index = _RISCV_Map_hardid_to_cpu_index(hart_index);
-    if (hart_index >= rtems_configuration_get_maximum_processors()) {
+#ifdef RTEMS_SMP
+    cpu_index = _RISCV_Map_hardid_to_cpu_index(hart_index);
+    if (cpu_index >= rtems_configuration_get_maximum_processors()) {
       continue;
     }
-
-    cpu = _Per_CPU_Get_by_index(hart_index);
-    cpu->cpu_per_cpu.clint_msip = &clint->msip[i / 16];
-    cpu->cpu_per_cpu.clint_mtimecmp = &clint->mtimecmp[i / 16];
 #else
     if (hart_index != RISCV_BOOT_HARTID) {
       continue;
     }
 
-    cpu = _Per_CPU_Get_by_index(0);
-    cpu->cpu_per_cpu.clint_msip = &clint->msip[i / 16];
-    cpu->cpu_per_cpu.clint_mtimecmp = &clint->mtimecmp[i / 16];
+    cpu_index = 0;
+#endif
+
+    riscv_clint_per_cpu_init(
+      clint,
+      _Per_CPU_Get_by_index(cpu_index),
+      (uint32_t) (i / 16)
+    );
+
+#ifndef RTEMS_SMP
+    break;
 #endif
   }
 }