[rtems-central commit] spec: Clarify interrupt handler dispatch

[Sebastian Huber]

Module:    rtems-central
Branch:    master
Commit:    690e0641c008b42cb5f29311d78c404f0e0e6939
Changeset: http://git.rtems.org/rtems-central/commit/?id=690e0641c008b42cb5f29311d78c404f0e0e6939

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Fri Feb  3 08:49:35 2023 +0100

spec: Clarify interrupt handler dispatch

---

 ...ml => interrupt-handler-dispatch-unchecked.yml} |  6 +-
 ...ml => interrupt-handler-dispatch-unchecked.yml} | 66 +++++++++++++---------
 2 files changed, 41 insertions(+), 31 deletions(-)

diff --git a/spec/bsp/if/interrupt-spurious.yml b/spec/bsp/if/interrupt-handler-dispatch-unchecked.yml
similarity index 67%
rename from spec/bsp/if/interrupt-spurious.yml
rename to spec/bsp/if/interrupt-handler-dispatch-unchecked.yml
index d643e739..fbeddbcb 100644
--- a/spec/bsp/if/interrupt-spurious.yml
+++ b/spec/bsp/if/interrupt-handler-dispatch-unchecked.yml
@@ -1,7 +1,7 @@
 SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
 copyrights:
-- Copyright (C) 2021 embedded brains GmbH (http://www.embedded-brains.de)
-enabled-by: RTEMS_SMP
+- Copyright (C) 2023 embedded brains GmbH (http://www.embedded-brains.de)
+enabled-by: true
 index-entries: []
 interface-type: unspecified-function
 links:
@@ -9,6 +9,6 @@ links:
   uid: header-2
 - role: interface-ingroup
   uid: group-interrupt
-name: bsp_interrupt_spurious
+name: bsp_interrupt_handler_dispatch_unchecked
 references: []
 type: interface
diff --git a/spec/bsp/req/interrupt-spurious.yml b/spec/bsp/req/interrupt-handler-dispatch-unchecked.yml
similarity index 88%
rename from spec/bsp/req/interrupt-spurious.yml
rename to spec/bsp/req/interrupt-handler-dispatch-unchecked.yml
index 31ed7dd7..22837802 100644
--- a/spec/bsp/req/interrupt-spurious.yml
+++ b/spec/bsp/req/interrupt-handler-dispatch-unchecked.yml
@@ -1,11 +1,11 @@
 SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
 copyrights:
-- Copyright (C) 2021 embedded brains GmbH (http://www.embedded-brains.de)
-enabled-by: RTEMS_SMP
+- Copyright (C) 2021, 2023 embedded brains GmbH (http://www.embedded-brains.de)
+enabled-by: true
 functional-type: action
 links:
 - role: interface-function
-  uid: ../if/interrupt-spurious
+  uid: ../if/interrupt-handler-dispatch-unchecked
 post-conditions:
 - name: Result
   states:
@@ -44,7 +44,7 @@ post-conditions:
   test-epilogue: null
   test-prologue: null
 pre-conditions:
-- name: First
+- name: LoadFirst
   states:
   - name: 'Null'
     test-code: |
@@ -62,7 +62,7 @@ pre-conditions:
       an object of type ${/rtems/intr/if/entry:/name}.
   test-epilogue: null
   test-prologue: null
-- name: FirstAgain
+- name: LoadFirstAgain
   states:
   - name: 'Null'
     test-code: |
@@ -91,23 +91,15 @@ test-action: |
   ctx->fatal_source = RTEMS_FATAL_SOURCE_LAST;
   ctx->fatal_code = UINT32_MAX;
 
-  #if defined(RTEMS_SMP)
-  if ( *ctx->first == NULL && ctx->first_again != NULL ) {
-    *ctx->first = ctx->first_again;
-    bsp_interrupt_spurious( ctx->test_vector );
-  } else
-  #endif
-  {
-    (void) rtems_interrupt_vector_enable( ctx->test_vector );
+  (void) rtems_interrupt_vector_enable( ctx->test_vector );
 
-    CallWithinISRRaise();
-
-    while ( !ctx->interrupt_occurred ) {
-      /* Wait */
-    }
+  CallWithinISRRaise();
 
-    Disable( ctx );
+  while ( !ctx->interrupt_occurred ) {
+    /* Wait */
   }
+
+  Disable( ctx );
 test-brief: null
 test-cleanup: null
 test-context:
@@ -254,7 +246,25 @@ test-support: |
       __real_bsp_interrupt_handler_default( vector );
     }
   }
-test-target: testsuites/validation/tc-bsp-interrupt-spurious.c
+
+  #if defined(RTEMS_SMP)
+  void __real_bsp_interrupt_spurious( rtems_vector_number vector );
+
+  void __wrap_bsp_interrupt_spurious( rtems_vector_number vector );
+
+  void __wrap_bsp_interrupt_spurious( rtems_vector_number vector )
+  {
+    if ( test_case_active ) {
+      Context *ctx;
+
+      ctx = T_fixture_context();
+      *ctx->first = ctx->first_again;
+    }
+
+    __real_bsp_interrupt_spurious( vector );
+  }
+  #endif
+test-target: testsuites/validation/tc-bsp-interrupt-handler-dispatch-unchecked.c
 test-teardown:
   brief: null
   code: |
@@ -273,27 +283,27 @@ transition-map:
     FatalSource: SpuriousInterrupt
     FatalCode: Vector
   pre-conditions:
-    First:
+    LoadFirst:
     - 'Null'
-    FirstAgain: N/A
+    LoadFirstAgain: N/A
 - enabled-by: true
   post-conditions:
     Result: Dispatch
     FatalSource: N/A
     FatalCode: N/A
   pre-conditions:
-    First:
+    LoadFirst:
     - Entry
-    FirstAgain: N/A
+    LoadFirstAgain: N/A
 - enabled-by: RTEMS_SMP
   post-conditions:
     Result: FatalError
     FatalSource: SpuriousInterrupt
     FatalCode: Vector
   pre-conditions:
-    First:
+    LoadFirst:
     - 'Null'
-    FirstAgain:
+    LoadFirstAgain:
     - 'Null'
 - enabled-by: RTEMS_SMP
   post-conditions:
@@ -301,8 +311,8 @@ transition-map:
     FatalSource: N/A
     FatalCode: N/A
   pre-conditions:
-    First:
+    LoadFirst:
     - 'Null'
-    FirstAgain:
+    LoadFirstAgain:
     - Entry
 type: requirement