[rtems commit] score: Help static analysis in thread init

Sebastian Huber sebh at rtems.org
Sat Jan 28 16:43:20 UTC 2023


Module:    rtems
Branch:    master
Commit:    453939753b7fd758b49631c6a8cba10d8fdddaf7
Changeset: http://git.rtems.org/rtems/commit/?id=453939753b7fd758b49631c6a8cba10d8fdddaf7

Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
Date:      Sat Jan 28 10:56:38 2023 +0100

score: Help static analysis in thread init

Add an assert to _Thread_Initialize_scheduler_and_wait_nodes() which may
help a static analyzer.  Use a do/while loop since we have at least one
scheduler.

Update #4832.

---

 cpukit/score/src/threadinitialize.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/cpukit/score/src/threadinitialize.c b/cpukit/score/src/threadinitialize.c
index 31698524a9..e1a6c7de93 100644
--- a/cpukit/score/src/threadinitialize.c
+++ b/cpukit/score/src/threadinitialize.c
@@ -139,7 +139,10 @@ static void _Thread_Initialize_scheduler_and_wait_nodes(
    * The application configuration ensures that we have at least one scheduler
    * configured.
    */
-  while ( scheduler_index < _Scheduler_Count ) {
+
+  _Assert ( _Scheduler_Count >= 1 );
+
+  do {
     Priority_Control priority;
 
     if ( scheduler == config->scheduler ) {
@@ -172,7 +175,7 @@ static void _Thread_Initialize_scheduler_and_wait_nodes(
       ( (uintptr_t) scheduler_node + _Scheduler_Node_size );
     ++scheduler;
     ++scheduler_index;
-  }
+  } while ( scheduler_index < _Scheduler_Count );
 
   /*
    * The thread is initialized to use exactly one scheduler node which is



More information about the vc mailing list