[rtems commit] bsp/tms570: Remove double pin configuration

Sebastian Huber sebh at rtems.org
Mon Jan 15 09:36:31 UTC 2024


Module:    rtems
Branch:    master
Commit:    39fd4b142ef9dced7522dcd18c9995133684ae1b
Changeset: http://git.rtems.org/rtems/commit/?id=39fd4b142ef9dced7522dcd18c9995133684ae1b

Author:    Tyler Miller <tyler.miller at airbusus.com>
Date:      Thu Dec 21 15:16:48 2023 +0100

bsp/tms570: Remove double pin configuration

Do not set pins to the default function before the actual setting is
applied.  If a pin setting needs to be done in a certain order, then
this should be done explicitly through multiple calls to
tms570_bsp_pinmmr_config().

Update #4982.

---

 bsps/arm/tms570/start/pinmux.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/bsps/arm/tms570/start/pinmux.c b/bsps/arm/tms570/start/pinmux.c
index d9c52cd00d..9277a36431 100644
--- a/bsps/arm/tms570/start/pinmux.c
+++ b/bsps/arm/tms570/start/pinmux.c
@@ -182,16 +182,6 @@ tms570_bsp_pinmmr_config(const uint32_t *pinmmr_values, int reg_start, int reg_c
   pval = pinmmr_values;
   cnt = reg_count;
 
-  do {
-    *pinmmrx = *pinmmrx & *pval;
-    pinmmrx++;
-    pval++;
-  } while( --cnt );
-
-  pinmmrx = (&TMS570_IOMM.PINMUX.PINMMR0) + reg_start;
-  pval = pinmmr_values;
-  cnt = reg_count;
-
   do {
     *pinmmrx = *pval;
     pinmmrx++;



More information about the vc mailing list