[PATCH] bsps/arm: replace CMSIS v4 with CMSIS v5 files

[Joel Sherrill]

On Thu, Jul 13, 2023 at 4:11 PM Karel Gardas <karel at functional.vision>
wrote:

>
>   Folks,
>
> please take this patch as an attempt to renew old discussion or rather
> start a new one focused solely on importing new ARM CMSIS code which is
> (i) under Apache 2 license but (ii) without any NOTICE file.
>

The absence of a NOTICE file is OK. If they had one, we would just have
to pass it along.

I recall the issue is that "You must cause any modified files to carry
prominent
notices stating that You changed the files"

If all changes are inside ifdef __rtems__ blocks like we do elsewhere would
this be sufficient? If we don't think that's "prominent", then adding a
single like
at the top of each file with the rtems conditional should be enough.
Something
like this:

/* Contains modifications for RTEMS */

>
> I hope technical advantages are huge and there is no hinder involved
> like with other possible Apache2 licensed projects with NOTICE file
> presented.
>

My reading is that we would need to pass the NOTICE file along. I personally
do not see that as a burden unless it contains more than credit or
permissively
license info.

>
> The patch itself is clear replace of existing files with a new files,
> plus required files added and old one not needed anymore removed.
>
> The patch was very lightly tested by building several ARM BSPs
> especially those affected by the change.
>

Did you have any BSPs to actually test on? What ones can be tested
for this?


>
> Thanks for any comments!
>

I'm happy with the update and think it is OK license wise. Technically, it
you
trust it, I'm ok with it.

>
> Karel
>
> On 7/13/23 23:05, Karel Gardas wrote:
> > CAVEAT: license change from BSD to Apache2 license!
> >
> > Explanation:
> > The imported files come from CMSIS v5 project available on:
> >
> > https://github.com/ARM-software/CMSIS_5/tree/develop
> >
> > The files imported are located inside the CMSIS/Core/Include
> > project sub-directory.
> >
> > The project does not provide any NOTICE file in its root directory nor
> > in the directory of the imported files.
> > The NOTICE file and its usage in the Apache 2 license was/is
> > so far the only issue mentioned in discussion of RTEMS developers/users
> > when considering inclusion of the code under Apache 2 license
> > into the RTEMS project.
> > Since the CMSIS v5 project is free from this legal hinder, we may freely
> > use it and update files to the latest version.
> >
> > Technical: the patch replaces code from 2015 with the latest version
> > which brings quite a lot of bug fixes and most importantly opens
> > possibilities to support MCUs based on new ARM cores.
> > ---
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20230713/a7ed44dc/attachment.htm>